Re: [Qemu-devel] [PATCH] ioemu/qemu vga: save and restore vram buffer (revised)

[Paul Brook]

> In any case, vl.c's saving arrangements do save the buffer in
> phys_ram_base - but that isn't what the guest sees in the VGA memory

It doesn't matter what the guest physical mappings (if any) are.

> area.  The guest sees the vga memory-mapped IO registers (whose
> meaning _is_ generally saved by vga.c), plus it can use the VGA memory
> area and those control registers to access the whole of s->vram_ptr in
> a bank-switched way.  And it is that whole VGA memory buffer which is
> `displayed' to (eg) vlc clients.

If you look closer, you'll find that s->vram_ptr actually points to an offset 
from phys_ram_base. So the VGA framebuffer is already saved by ram_save.

If the xen patches have changed this then you may need your patch. It has no 
business in mainstream qemu though.

Paul