Re: [Qemu-devel] [PATCH 2/2] Real SCSI device passthrough (v3)

[Anthony Liguori]

Laurent Vivier wrote:
> Le vendredi 07 décembre 2007 à 15:22 +0000, Paul Brook a écrit :
>   
> > On Friday 07 December 2007, Laurent Vivier wrote:
> >     
> > > -    acb->aiocb.aio_nbytes = nb_sectors * 512;
> > > +    if (nb_sectors < 0)
> > > +        acb->aiocb.aio_nbytes = -nb_sectors;
> > > +    else
> > > +        acb->aiocb.aio_nbytes = nb_sectors * 512;
> > >       
> > Ugly hacks like this need at least a decent comment.
> >     
>
> Yes, you're right but I'm always wondering if it is the good way to do
> what I want: read a number of bytes instead of a number of sectors.
> Perhaps I should define a new function in the qemu AIO interface ?
>   

I think the crux of the problem is that you're using the BlockDriver API 
for something that isn't actually a block driver.

Regards,

Anthony Liguori

> There is another ugly hack, did you find it ? ;-)
>
> Laurent
>