Re: [Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

[Tristan Gingold]

On Nov 29, 2007, at 4:07 PM, Carlo Marcelo Arenas Belon wrote:

> On Thu, Nov 29, 2007 at 02:05:36PM +0100, Tristan Gingold wrote:
> > according to ATA std:
>
> which ATA std?

A rather old one: ATA-3

> >   The pending interrupt condition shall be set by:
> >   ??? the completion of a command; or
> >
> > This patch sends an irq for WIN_DIAGNOSE (and WIN_SRST)
>
> DEVICE RESET or DEVICE DIAGNOSTIC in T13/1153D revision 18 don't  
> ask for an
> irq.

Well, not just after the command is executed.  But according to 9.5.1  
of 1153D:

l) After completing the above steps, Device 0 shall assert INTRQ if  
nIEN is cleared to zero.

So the IRQ is asserted at the end of diagnostic.

> what is the use case you are trying to solve? which guest OS?

The OS timeout during diagnostic.

Tristan.