Re: [Qemu-devel] another patch against head

[Johannes Schindelin]

Hi Hotmail,

On Tue, 27 Nov 2007, Hotmail wrote:

> The following is another patch against the head that lets me build it on 
> Windows, as well as makes the adlib.c file debuggable.
> 
> Index: Makefile
> ===================================================================
> RCS file: /sources/qemu/qemu/Makefile,v
> retrieving revision 1.136
> diff -r1.136 Makefile
> 17a18,20
> > ifdef CONFIG_WIN32
> > LIBS= -lmingw32 -mno-cygwin
> > else
> 18a22
> > endif

So you build it in Cygwin, not "on Windows".

> Index: cocoa.m
> ===================================================================
> RCS file: /sources/qemu/qemu/cocoa.m,v
> retrieving revision 1.14
> diff -r1.14 cocoa.m
> 754c754
> <         [op beginSheetForDirectory:nil file:nil types:[NSArray 
> arrayWithObjects:@"img",@"iso",@"dmg",@"qcow",@"cow",@"cloop",@"vmdk",nil]
> ---
> >         [op beginSheetForDirectory:nil file:nil types:[NSArray 
> > arrayWithObjects:@"img",@"iso",@"dmg",@"qcow",@"qcow2",@"cow",@"cloop",@"vmdk",nil]

How does this help compiling on Windows?

> Index: monitor.c
> ===================================================================
> RCS file: /sources/qemu/qemu/monitor.c,v
> retrieving revision 1.87
> diff -r1.87 monitor.c
> 31a32
> > #include "qemu-timer.h"
> Index: hw/adlib.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/adlib.c,v
> retrieving revision 1.8
> diff -r1.8 adlib.c
> 25a26
> > #include "audio/audio.h"
> 26a28
> > #include "qemu-timer.h"

Why are these needed?  It appears that all other platforms build QEmu just 
fine without these #includes.

But then, the answer to that riddle could be in the context.  Since you 
did not use the unified diff format, I have no chance to know.

Ciao,
Dscho