[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target_posix_types.h
From: |
Jocelyn Mayer |
Subject: |
Re: [Qemu-devel] [PATCH] target_posix_types.h |
Date: |
Wed, 14 Nov 2007 18:54:11 +0100 |
On Wed, 2007-11-14 at 17:36 +0000, Thiemo Seufer wrote:
> Jocelyn Mayer wrote:
> >
> > On Wed, 2007-11-14 at 08:59 -0700, Thayne Harbaugh wrote:
> > > This patch, 44_target_posix_types.patch provides target specific posix
> > > types. These types improve target structure creation, code similarity
> > > to kernel code and improve type casting for assignment between target
> > > and host.
> >
> > Hi,
> >
> > This seems not OK for ppc/ppc64. There is no ppc64 subdirectory anymore
> > in the linux-user directory. ppc and ppc64 targets have been merged, as
> > it is in recent kernels, so all the definitions should go in the ppc
> > subdirectory, using #ifdef TARGET_PPC64 when there are differences; but
> > there should be very few: there are only 2 ifdef __powerpc64__ in the
> > linux-2.6.23/include/asm-powerpc/posix_types.h file.
>
> I figure some conditionals went missing, on 32-bit Linux/ppc it fails to
> compile.
[...]
Ooops... Thanks for the report, it looks like T0_64, ..., are not
properly declared in this case. I'll take a look.
--
Jocelyn Mayer <address@hidden>
- [Qemu-devel] [PATCH] target_posix_types.h, Thayne Harbaugh, 2007/11/14
- [Qemu-devel] Re: [PATCH] tget/tput deprecation, Thayne Harbaugh, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Jocelyn Mayer, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Fabrice Bellard, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Thayne Harbaugh, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Fabrice Bellard, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Thayne Harbaugh, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Paul Brook, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Warner Losh, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Thayne Harbaugh, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Thayne Harbaugh, 2007/11/14
- Re: [Qemu-devel] [PATCH] target_posix_types.h, Paul Brook, 2007/11/14