[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] error compiling hw/sh7750.c
From: |
Carlo Marcelo Arenas Belon |
Subject: |
Re: [Qemu-devel] error compiling hw/sh7750.c |
Date: |
Sun, 11 Nov 2007 12:03:48 -0600 |
User-agent: |
Mutt/1.4.1i |
On Sun, Nov 11, 2007 at 05:24:06PM +0000, Paul Brook wrote:
> > +#undef NULL
> > +#define NULL ((void *)0)
>
> Absolutely not.
this was not meant to be a final solution, or even be committed in qemu, just
a stop gap solution answering Ben so that he can get their build to complete
and have a somehow equivalent definition of what the code is doing in linux
(where I presume was tested) until it can be fixed in a portable way.
Ben's solution was to replace _INTC_ARRAY(NULL) with "NULL, NULL" but it
should had been instead "NULL, 4" or "NULL, 8" depending on what ISA he is
compiling it for, doing the "#undef/#define" leads to that and, yes I agree
it is awful.
Carlo