Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom

[Anthony Liguori]

andrzej zaborowski wrote:
> On 29/10/2007, Daniel P. Berrange <address@hidden> wrote:
>   
> > On Mon, Oct 29, 2007 at 03:49:18PM +0100, andrzej zaborowski wrote:
> >     
> > > On 29/10/2007, Daniel P. Berrange <address@hidden> wrote:
> > >       
> > > > On Sun, Oct 28, 2007 at 11:43:33PM +0100, address@hidden wrote:
> > > >         
> > > > > From: Laurent Vivier <address@hidden(none)>
> > > > >
> > > > > This patch allows to define where is connected the CDROM device (bus,
> > > > > unit).
> > > > > It extends the "-cdrom" syntax to add these paramaters:
> > > > >
> > > > >      -cdrom file[,if=type][,bus=n][,unit=m]
> > > > >
> > > > >  where "type" defines the interface (by default, "ide")
> > > > >        "n" defines the bus number (by default 1)
> > > > >        "m" defines the unit number (by default 0)
> > > > >           
> > > > Having a separately named arg just for CDROMs was always rather odd/unhelpful.
> > > > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged
> > > > and use the -disk for setting up all types of disks, floppys, cdroms, etc. It
> > > > would just require one extra field for the -disk arg:
> > > >         
> > > Sounds logical and I thought this was the plan. I also wouldn't mind
> > > having -sda, -sdb... following the intuitive naming based on linux
> > > /dev, but IIRC there were some people on the list who didn't like this
> > > idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent
> > > systems, but it's still the most intuitive name for most users).
> > >       
> > Adding more -sda arguments is just asking for trouble. On recent Fedora,
> > even IDE disks will end up as /dev/sdNNN named devices. So what happens
> > when you have -hda & -sda at same time.... pain & suffering is what
> > happens :-) Avoiding device names as args by just using -disk is nicer
> >     
>
> Apart from the -sda discussion (which I still think is the most
> intuitive choice, as an alias), I don't think having IDE and SCSI
> disks in one machine should be any concern?
>   

I agree that -sda is more intuitive at the moment but I think what Dan 
is pointing out is that in the future, -hda may end up not being used in 
the distros at all so while -hda/-sda makes sense today, in a couple 
years it may become a source of confusion.

While -disk seems a bit painful, it probably is the most intuitive thing 
to use in the long run.

Regards,

Anthony Liguori

> Regards
>
>
>
>