Re: [Qemu-devel] qemu/target-sparc exec.h op.c op_helper.c op_me...

[Aurelien Jarno]

On Fri, Sep 21, 2007 at 11:20:26PM +0200, Andreas Färber wrote:
> Am 21.09.2007 um 23:07 schrieb Aurelien Jarno:
> 
> >Aurelien Jarno a écrit :
> >>On Fri, Sep 21, 2007 at 09:32:00PM +0200, Andreas Färber wrote:
> >>>These changes appear to have broken sparc32-softmmu on OS X v10.4
> >>>ppc: The OpenBIOS screen no longer appears.
> >>>
> >>
> >>Could you try to see if qemu.log contains useful debug information  
> >>while
> >>running in debug mode?
> >>
> >>I am currently building qemu-sparc on a powerpc (GNU/Linux) to try to
> >>reproduce the problem, but my machine isn't really fast, it will take
> >>some time.
> >
> >I am able to reproduce it, so it's probably an endianness problem.  
> >I am
> >debugging...
> 
> I have been unable to enter the monitor... If you need more  
> information from me, please provide detailed instructions how to  
> obtain the requested log file.
> 

Unfortunately I don't have the same symptoms, so I am not sure it is the
same problem. In my case the bug has been introduced by the iommu commit
which does not consider big endian hosts.

The patch below fixes the problem in my case. Could you please try it?

Index: hw/iommu.c
===================================================================
RCS file: /sources/qemu/qemu/hw/iommu.c,v
retrieving revision 1.15
diff -u -d -p -r1.15 iommu.c
--- hw/iommu.c  20 Sep 2007 16:01:51 -0000      1.15
+++ hw/iommu.c  22 Sep 2007 11:45:55 -0000
@@ -212,7 +212,7 @@ static uint32_t iommu_page_get_flags(IOM
     addr &= ~s->iostart;
     iopte += (addr >> (PAGE_SHIFT - 2)) & ~3;
     cpu_physical_memory_read(iopte, (uint8_t *)&ret, 4);
-    bswap32s(&ret);
+    tswap32s(&ret);
     DPRINTF("get flags addr " TARGET_FMT_plx " => pte " TARGET_FMT_plx
             ", *pte = %x\n", pa, iopte, ret);
 

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net