[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu Makefile.target cpu-all.h cpu-exec.c dynge
Re: [Qemu-devel] [PATCH] qemu Makefile.target cpu-all.h cpu-exec.c dynge...
Wed, 9 May 2007 01:02:04 +0100
Stefan Weil wrote:
I cherrypicked the easy bits, and will look at the rest when I have
> When I started to write MIPS host, I found it difficult to
> get all locations which needed new code. To make it easier for
> new ports, I changed sequences of #if ... #endif, #if ... #endif
> into #if ... #elif ... #elif ... #else #error #endif.
Some of those folded unrelated things together, I committed a different
patch based on yours.
> Other changes include some smaller spelling corrections.
> Most important was Johannes code for testandset and PARAMn.
AFAICS that testandset implementation is broken, and I think
mine is correct, maybe except for the +R vs. +m bit in the asm
Did my implementation fail for you?
> The patch still includes your relocation code, but it is disabled
> and uses my own code. I had no time to check or try the differences.
Then I gather there's no particular reason why my _PC16 reloc code
is deleted in the patch.