qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] Crop VNC update requests to avoid segfaults


From: Thomas Tuttle
Subject: [Qemu-devel] [PATCH] Crop VNC update requests to avoid segfaults
Date: Sun, 08 Apr 2007 20:40:11 -0400
User-agent: Mutt/1.5.13 (2006-08-11)

I was booting a guest that lowered the screen resolution after I logged
in, so my VNC client was running at a larger resolution (1024x768) than
the actual Qemu framebuffer's resolution (800x600).  When the VNC client
requested an update, Qemu tried to set the dirty bits and memset the
data for an area of the screen that was non-existant, and it segfaulted.

I've written a patch that "crops" the coordinates (both x and y, even
though only y is actually used) of the update region to the actual size
of the display to avoid this problem.  It is attached.  I made it
against Qemu CVS.

Comments, suggestions, and constructive criticism is appreciated.

Thank you,

Thomas Tuttle

Attachment: qemu-crop-vnc-update.patch
Description: Text document

Attachment: pgpI0GqGixVX9.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]