[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Implement Win32 locking in vl.c (create_pidfile
Re: [Qemu-devel] [PATCH] Implement Win32 locking in vl.c (create_pidfile).
Sun, 25 Mar 2007 12:58:01 -0500
Thunderbird 126.96.36.199 (X11/20070307)
Carlos O'Donell wrote:
The following patch implements Win32 locking for vl.c (create_pidfile).
Builds for mingw32, and tested on a Windows Server 2003 host by running
two qemu's with the same -pidfile option.
When cross-compiling the use of --enable-mingw32 should effect AIOLIBS,
otherwise the build will use "-lrt" and this is not valid when compiling
Instead of using an #ifdef, I think it would be better to have a win32
specific file and a unix specific file that compiles conditionally
depending on the host.
Sort of like and osdep-posix.c and and osdep-win32.c. Both would
implement a create_pidfile() function. I think this general approach
would help clean up a lot of the win32 code.
Patch attached for both. Built on linux and tested on Windows Server
Comments? Please include me in the CC.