[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fcntl64 fix
From: |
Stuart Anderson |
Subject: |
Re: [Qemu-devel] [PATCH] fcntl64 fix |
Date: |
Tue, 20 Mar 2007 19:05:33 -0400 (EDT) |
On Tue, 20 Mar 2007, Thiemo Seufer wrote:
Still, this part makes no sense to me since it is in a packed struct.
Can you explain why this works better for you?
It worked better, in that it fixed a problem that let me continue on to
fix other issues. After revisiting fcntl() and coming up with the more
comprehensive patch, this change now seems to have no effect, so I
must conceed that it is not needed, please drop that part of the patch.
Now that the dust has settled, I see where the change is probably a
no-op anyway. A quick little test program indicates that on x86_64,
l_start will have an offset of 8 wether the structure is packed or not,
and wether the __pad member is present or not. The unsigned long long is
always going to be aligned to a 8 byte boundary.
Stuart
Stuart R. Anderson address@hidden
Network & Software Engineering http://www.netsweng.com/
1024D/37A79149: 0791 D3B8 9A4C 2CDC A31F
BD03 0A62 E534 37A7 9149
- Re: [Qemu-devel] [PATCH] fcntl64 fix, (continued)
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/20
- Message not available
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Stuart Anderson, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Stuart Anderson, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Stuart Anderson, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Stuart Anderson, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Paul Brook, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Thiemo Seufer, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix,
Stuart Anderson <=
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Paul Brook, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Stuart Anderson, 2007/03/21
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/25
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/20
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Stuart Anderson, 2007/03/21
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/25
- Re: [Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/22
[Qemu-devel] [PATCH] fcntl64 fix, Kirill A. Shutemov, 2007/03/25