qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] ARM MMU translation - fix small (4k) page access


From: Scott Oom
Subject: [Qemu-devel] [PATCH] ARM MMU translation - fix small (4k) page access
Date: Fri, 02 Feb 2007 00:20:41 -0500
User-agent: Icedove 1.5.0.9 (X11/20061220)

Hello,
Found a problem when using small pages and getting permission faults.
This patch corrects the decoding of access permissions for small pages
on ARM, was just off by 2 bits.

-Scott
Index: target-arm/helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-arm/helper.c,v
retrieving revision 1.8
diff -u -3 -p -r1.8 helper.c
--- target-arm/helper.c 20 Jan 2007 17:12:09 -0000      1.8
+++ target-arm/helper.c 2 Feb 2007 05:12:03 -0000
@@ -338,7 +338,7 @@ static int get_phys_addr(CPUState *env, 
                 break;
             case 2: /* 4k page.  */
                 phys_addr = (desc & 0xfffff000) | (address & 0xfff);
-                ap = (desc >> (4 + ((address >> 13) & 6))) & 3;
+                ap = (desc >> (4 + ((address >> 11) & 6))) & 3; /* SRO */
                 break;
             case 3: /* 1k page.  */
                 if (type == 1) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]