qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [patch] factor out commonly used scancode translation t


From: Jonathan Phenix
Subject: Re: [Qemu-devel] [patch] factor out commonly used scancode translation table
Date: Thu, 04 Jan 2007 12:52:56 -0500
User-agent: Thunderbird 1.5.0.8 (X11/20061107)

Bernhard Fischer wrote:
Hi,

The attached patch moves the x_keycode_to_pc_keycode LUT from sdl.c into
an x_keycode.c. This struct is also used by the GGI backend (that is not
yet merged ¹).

Comments?
How it is done right now, each time x_keycode.c is included, you will end up with an extra copy in the final executable. Perhaps that simply keeping the LUT in sdl.c but removing the 'static' keyword from it and creating a sdl.h file with the statement:

extern const uint8_t *x_keycode_to_pc_keycode;

would be a better idea. Including a header file is more clean than including a C file as well.
Please apply.

¹)
http://members.aon.at/berny_f/qemu/qemu-HEAD.ggi-2.2.x-04c-20070104.diff
_______________________________________________
Qemu-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/qemu-devel






reply via email to

[Prev in Thread] Current Thread [Next in Thread]