qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] cpustate patch


From: Fabrice Bellard
Subject: Re: [Qemu-devel] cpustate patch
Date: Thu, 14 Sep 2006 23:23:50 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913

Rafael EspĂ­ndola wrote:
While hunting a tls related bug in ARM emulation, I found that that
qemu distributed with scratchbox includes the attached patch.

Without the patch python's configure halts when checking for the
-pthread option.

The patch inverts the order of the list and makes the code simpler. I
think that there is a remaining problem, if first_cpu == NULL then
env->cpu_index is not initialized. Should an else be added?

Any thoughts on the patch?

For consistency I prefer that the first cpu of the list is number zero, so I prefer to leave the code as it is now.

Regards,

Fabrice.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]