[Qemu-devel] Re: esd audio output patch and debuging.

[malc]

Frederick Reeve <cylix <at> solace.info> writes:

> 
> Hello.
> 
> Attached you will find a patch for esd audio support in QEMU.  It is more or
less a large modification of
> audio/wavaudio.c. The patch will apply against the latest tarball release
> http://fabrice.bellard.free.fr/qemu/qemu-0.8.2.tar.gz (0.8.2 at the time of
this writing).  You
> will of course need libesd to compile this.  To apply and test on linux/*nix
simply:
> 
> $ cd qemu-src-dir
> $ patch -Np1 -i path/to/patch/file
> $ ./configure --enable-esd
> $ make
> $ sudo make install
> $ export QEMU_AUDIO_DRV=esd
> $ qemu (your options here) -soundhw es1370
> 

[..snip..]

There are several problems with this patch:

a. esd_play_stream returns negative values on error (not zero)
b. esd_play_stream can return with EINTR
c. no error checking whatsoever on write to the socket
d. the socket is most likely opened in blocking mode
e. i don't think it's wise to use anything other than esd itself
   as a audio-clock source

So basically the only way it can work (given the circumstances)
is to have a thread that would perform a blocking write to the
esd, and the rest as per coreaudio and sdladuio.

P.S. Oh yeah, mixing tabs and spaces is also not a great idea.