|
From: | Fabrice Bellard |
Subject: | Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support |
Date: | Sat, 24 Jun 2006 17:08:41 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913 |
Raphaël Rigo wrote:
Raphaël Rigo wrote:Fabrice Bellard wrote:Another point is that doing: + target_long args[6]; + + tputl(args, arg1); + tputl(args+1, arg2); + tputl(args+2, arg3); + tputl(args+3, arg4); + tputl(args+4, arg5); + tputl(args+5, arg6); at the start of every syscall is not acceptable. You should add a specific socket call wrapper which takes arg1... arg6 as arguments. Regards, Fabrice.Thanks for reviewing it, the new attached version should be much cleaner. Regards, RaphaëlSorry to insist, but can you please include it in the CVS? I really think it's useful.
I applied it and added "getsockopt". In fact, you should completely suppress do_socketcallwrapper() (using tputl and tgetl for non user access is bad).
Regards, Fabrice.
[Prev in Thread] | Current Thread | [Next in Thread] |