qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Patch] Kqemu patch for 2.6.17-rc2


From: Leonardo E. Reiter
Subject: Re: [Qemu-devel] [Patch] Kqemu patch for 2.6.17-rc2
Date: Tue, 06 Jun 2006 10:15:46 -0400
User-agent: Mozilla Thunderbird 1.0.8 (X11/20060502)

Hi,

I'm attaching a small update to Thomas's patch which conditionally enables this based on kernel version. As far as I can tell (from very brief research), module_param became available very late in 2.4. Also, the old version (MODULE_PARM) is supported in most 2.6 kernels as well. I picked arbitrarily 2.6.10 as the break-off point - it's really easy to change that to be something else. In any case, Fabrice, can you think about applying this, or something very similar, as it looks like MODULE_PARM has been finally abandoned in the latest kernels.

Regards,

Leo Reiter

Thomas Petazzoni wrote:
Hi,

On 2.6.17-rc2, the MODULE_PARM() way of declaring module parameters
seems to have disappeared (it is anyway deprecated since the beginning
of the 2.6 series). As such, kqemu-1.3.0pre7 doesn't compile.

--
Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing that means Business
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com
--- kqemu-linux.c.orig  2006-06-06 10:06:03.000000000 -0400
+++ kqemu-linux.c       2006-06-06 10:09:41.000000000 -0400
@@ -49,7 +49,11 @@
 /* if 0 is used, then devfs/udev is used to automatically create the
    device */
 int major = 250;
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,10)
 MODULE_PARM(major,"i");
+#else
+module_param(major, int, 0);
+#endif
 
 /* Lock the page at virtual address 'user_addr' and return its
    physical address (page index). Return a host OS private user page

reply via email to

[Prev in Thread] Current Thread [Next in Thread]