Re: [Qemu-devel] Updated BGR vs. RGB vga patch...

[Leonardo E. Reiter]

Probably... I just don't know anything about SDL and I needed this patch 
to work right away with at least the command-line option.  It's 
definitely deducible from X11, and that's very easy.

- Leo Reiter

malc wrote:
> On Mon, 10 Apr 2006, Leonardo E. Reiter wrote:
>
> > Anyway, I didn't spend time figuring out how to query SDL for the 
> > ordering. You still have to manually pass in -bgr.  The good news is 
> > that all the computation is now done at compile-time, with only very 
> > few tests done at run-time.  I agree with your assessment of 
> > compile-time versus run-time options... I was merely suggesting a 
> > compromise to fend off the minor performance hit of using the old 
> > patch.  But the method you suggested is much better and that's how 
> > it's implemented now.
>
>
> I maybe going out on a limb here, but isn't rgb/bgr trivially deducible
> from: sdl.c:screen->format->[RGBA]shift.

--
Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing from Desktop to Data Center
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com