[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] PC speaker emulation (fixed)

From: Joachim Henke
Subject: [Qemu-devel] [PATCH] PC speaker emulation (fixed)
Date: Thu, 19 Jan 2006 21:44:56 +0100

Thanks a lot for your help! I wasn't aware that AUD_write could return zero. Seems that I was just lucky, it didn't do that with 44100 Hz sample rate (c:

Now it works fine with 32000 Hz, and I really encourage people (especially PC users) to test the attached patch. Call QEMU with the switch '-soundhw pcspk', and try to make some noise.


malc wrote:
b. Once AUD_write return zero one should stop writing untill some space
   becomes available (for all intents and purposes after callback
   will be called next time)

Item b is probably why it hangs: you try to write N bytes, AUD_write
returns zero, yet you are tring again immediately - ad nauseam. We
have only one thread - hence audio can not push the data out of
internal buffers into the host, and what you get is an infinite loop.

Joachim Henke

Attachment: pcspeaker.diff.gz
Description: GNU Zip compressed data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]