qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [parch] Incorrect IO index overflow check


From: Paul Brook
Subject: [Qemu-devel] [parch] Incorrect IO index overflow check
Date: Sat, 29 Oct 2005 21:29:28 +0100
User-agent: KMail/1.8.2

The attached patch fixes an incorrect overflow check in 
cpu_register_io_memory.

Paul
Index: exec.c
===================================================================
RCS file: /cvsroot/qemu/qemu/exec.c,v
retrieving revision 1.65
diff -u -p -r1.65 exec.c
--- exec.c      3 Sep 2005 10:49:04 -0000       1.65
+++ exec.c      29 Oct 2005 20:25:10 -0000
@@ -2095,14 +2095,11 @@ int cpu_register_io_memory(int io_index,
     int i;
 
     if (io_index <= 0) {
-        if (io_index >= IO_MEM_NB_ENTRIES)
-            return -1;
         io_index = io_mem_nb++;
-    } else {
-        if (io_index >= IO_MEM_NB_ENTRIES)
-            return -1;
     }
-    
+    if (io_index >= IO_MEM_NB_ENTRIES)
+        return -1;
+
     for(i = 0;i < 3; i++) {
         io_mem_read[io_index][i] = mem_read[i];
         io_mem_write[io_index][i] = mem_write[i];

reply via email to

[Prev in Thread] Current Thread [Next in Thread]