Re: [Qemu-devel] [PATCH] Better .dmg autodetection

[J. Mayer]

On Tue, 2005-04-12 at 19:28 +0200, Alex Beregszaszi wrote:
> Hi,
> 
> There are quiet lot fake dmg files floating around. These are just raw
> images containing the Apple partition map and HFS partitions.

Those are not fake dmg.
With Apple disk utility, you are free to choose if the dmg is to be
compressed or not.
Then, uncompressed dmg are valid ones.
But, you don't need to manage them in block-dmg,c as those are just raw
images...

[...]
> * last check if the filename ends in .dmg

It seems to me that this check is not to be done.
There's no need to. If the first sector (after decompression, if needed)
is a valid Apple partition map _or_ a valid partition entry (ie with PM
magic at start), then it's a valid dmg. File extensions never mean
anything, they are just a user-interface oriented remainder, imho.

-- 
J. Mayer <address@hidden>
Never organized