[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] security_20040618
From: |
Gianni Tedesco |
Subject: |
Re: [Qemu-devel] [PATCH] security_20040618 |
Date: |
Sat, 19 Jun 2004 16:26:08 +0100 |
On Sat, 2004-06-19 at 08:19 -0700, Tim wrote:
> > In dyngen you need to do:
> >
> > if ( ptr == NULL )
> > error("malloc failed");
> >
> > error() will never return.
> >
> > For the other places it depends, but it's ususally quite simple. Why not
> > have a stab and submit a seperate patch on top of this one?
>
> You would prefer I submit a seperate patch for the malloc fixes? I
> could certainly do that, but I just figured it is all a general code
> quality patch, which changes very few lines of code (though in many
> files). What would you prefer Fabrice?
Well, I meant if you were to go ahead and implement all the TODOs and
handle all the malloc returns properly. I'd submit that as a seperate
patch, i mean, if you aren't 100% confident of your analyses.
--
// Gianni Tedesco (gianni at scaramanga dot co dot uk)
lynx --source www.scaramanga.co.uk/scaramanga.asc | gpg --import
8646BE7D: 6D9F 2287 870E A2C9 8F60 3A3C 91B5 7669 8646 BE7D
signature.asc
Description: This is a digitally signed message part
- [Qemu-devel] [PATCH] security_20040618, Tim, 2004/06/18
- Re: [Qemu-devel] [PATCH] security_20040618, Vladimir N. Oleynik, 2004/06/19
- Re: [Qemu-devel] [PATCH] security_20040618, Tim, 2004/06/19
- [Qemu-devel] Re: [PATCH] security_20040618, Charlie Gordon, 2004/06/20
- Re: [Qemu-devel] Re: [PATCH] security_20040618, Tim, 2004/06/20
- [Qemu-devel] Re: Re: [PATCH] security_20040618, Charlie Gordon, 2004/06/20
- Re: [Qemu-devel] Re: Re: [PATCH] security_20040618, Tim, 2004/06/20
- OT: C Q/As, was Re: [Qemu-devel] security_20040618, Christof Petig, 2004/06/21