[Qemu-commits] [qemu/qemu] a8df48: thunk: improve readability of allocation loop

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a8df4845a093e79f9517da7a8e03937f85e9c6d9
      
https://github.com/qemu/qemu/commit/a8df4845a093e79f9517da7a8e03937f85e9c6d9
  Author: Aarushi Mehta <address@hidden>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M thunk.c

  Log Message:
  -----------
  thunk: improve readability of allocation loop

Signed-off-by: Aarushi Mehta <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 96f209b946e400d1cca3b86331570843ee4c6243
      
https://github.com/qemu/qemu/commit/96f209b946e400d1cca3b86331570843ee4c6243
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M hw/nvram/fw_cfg.c
    M include/sysemu/sysemu.h
    M vl.c

  Log Message:
  -----------
  hw/nvram/fw_cfg: Remove the unnecessary boot_splash_filedata_size

The 'boot_splash_filedata_size' was introduced as a global variable
in 3d3b8303c6f. This variable is used as a 'size' argument to the
fw_cfg_add_file(). This function has an interface contract with its
'data' argument, but there is no such contract for 'size' (this is
not a referenced pointer).  We can simply remove it.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 4a90846d6f61065140ff4c610bee6b4e385372f0
      
https://github.com/qemu/qemu/commit/4a90846d6f61065140ff4c610bee6b4e385372f0
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M hw/acpi/piix4.c

  Log Message:
  -----------
  hw/i386: Remove unused include

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 945309260d79de0df98c47ca078447a76fd70ec6
      
https://github.com/qemu/qemu/commit/945309260d79de0df98c47ca078447a76fd70ec6
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M hw/arm/virt.c

  Log Message:
  -----------
  hw/arm/virt: Remove null-check in virt_build_smbios()

Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board",
2014-12-22), the machvirt_init() unconditionally creates the
fw_cfg object.  Later, commit c30e15658b1b ("smbios: implement
smbios support for mach-virt", 2015-09-07) added a superfluous
null-check on it.
Remove this superfluous check.

Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 3b777a79c1cfa40f39f96220bc733eccd7392c9c
      
https://github.com/qemu/qemu/commit/3b777a79c1cfa40f39f96220bc733eccd7392c9c
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M hw/nvram/fw_cfg.c

  Log Message:
  -----------
  hw/nvram/fw_cfg: Use the ldst API

The load/store API eases code review.

Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: a6d3c238034c8a90a0a2cee7814741ff1384e66f
      
https://github.com/qemu/qemu/commit/a6d3c238034c8a90a0a2cee7814741ff1384e66f
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-12 (Tue, 12 Mar 2019)

  Changed paths:
    M hw/acpi/piix4.c
    M hw/arm/virt.c
    M hw/nvram/fw_cfg.c
    M include/sysemu/sysemu.h
    M thunk.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-pull-request' into staging

fw_cfg and thunk code clean up

# gpg: Signature made Mon 11 Mar 2019 19:11:03 GMT
# gpg:                using RSA key F30C38BD3F2FBE3C
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-pull-request:
  hw/nvram/fw_cfg: Use the ldst API
  hw/arm/virt: Remove null-check in virt_build_smbios()
  hw/i386: Remove unused include
  hw/nvram/fw_cfg: Remove the unnecessary boot_splash_filedata_size
  thunk: improve readability of allocation loop

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/eda1df0345f5...a6d3c238034c