[Qemu-commits] [qemu/qemu] 8821b3: aio-posix: Unregister fd from ctx epoll when remov...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8821b34a7362d69b325c045dad4557782775683b
      
https://github.com/qemu/qemu/commit/8821b34a7362d69b325c045dad4557782775683b
  Author: Remy Noel <address@hidden>
  Date:   2019-01-14 (Mon, 14 Jan 2019)

  Changed paths:
    M util/aio-posix.c

  Log Message:
  -----------
  aio-posix: Unregister fd from ctx epoll when removing fd_handler.

Cleaning the events will cause aio_epoll_update to unregister the fd.
Otherwise, the fd is kept registered until it is destroyed.

Signed-off-by: Remy Noel <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: fef1660132b0f25bf2d275d7f986ddcfe19a4426
      
https://github.com/qemu/qemu/commit/fef1660132b0f25bf2d275d7f986ddcfe19a4426
  Author: Remy Noel <address@hidden>
  Date:   2019-01-14 (Mon, 14 Jan 2019)

  Changed paths:
    M util/aio-posix.c
    M util/aio-win32.c

  Log Message:
  -----------
  aio-posix: Fix concurrent aio_poll/set_fd_handler.

It is possible for an io_poll callback to be concurrently executed along
with an aio_set_fd_handlers. This can cause all sorts of problems, like
a NULL callback or a bad opaque pointer.

This changes set_fd_handlers so that it no longer modify existing handlers
entries and instead, always insert those after having proper initialisation.

Tested-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Remy Noel <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 4b9f0b0f7c84eea2dfb0d5be3e0254bc91319dbc
      
https://github.com/qemu/qemu/commit/4b9f0b0f7c84eea2dfb0d5be3e0254bc91319dbc
  Author: Peter Maydell <address@hidden>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M util/aio-posix.c
    M util/aio-win32.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Pull request

No user-visible changes.

# gpg: Signature made Mon 14 Jan 2019 16:32:19 GMT
# gpg:                using RSA key 9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  aio-posix: Fix concurrent aio_poll/set_fd_handler.
  aio-posix: Unregister fd from ctx epoll when removing fd_handler.

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/44ba60106356...4b9f0b0f7c84
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.