[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 0b5700: replay: Exit on errors reading from r
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 0b5700: replay: Exit on errors reading from replay log |
Date: |
Thu, 08 Nov 2018 06:42:05 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 0b57007755c2ee442740b5321ffc7072aed88714
https://github.com/qemu/qemu/commit/0b57007755c2ee442740b5321ffc7072aed88714
Author: Peter Maydell <address@hidden>
Date: 2018-11-08 (Thu, 08 Nov 2018)
Changed paths:
M replay/replay-internal.c
Log Message:
-----------
replay: Exit on errors reading from replay log
Currently replay_get_byte() does not check for an error
from getc(). Coverity points out (CID 1390622) that this
could result in unexpected behaviour (such as looping
forever, if we use the replay_get_dword() return value
for a loop count). We don't expect reads from the replay
log to fail, and if they do there is no way we can
continue. So make them fatal errors.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Pavel Dovgalyuk <address@hidden>
Message-id: address@hidden
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 0b5700: replay: Exit on errors reading from replay log,
GitHub <=