qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 124242: edid: Ignore built binary


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 124242: edid: Ignore built binary
Date: Mon, 08 Oct 2018 02:01:55 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1242429b20ddcd7f1ad046ac8750c486938f2cbb
      
https://github.com/qemu/qemu/commit/1242429b20ddcd7f1ad046ac8750c486938f2cbb
  Author: Eric Blake <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  edid: Ignore built binary

Added in commit 72d277a7.

Signed-off-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 5a358b39f52a28a84b380c1685c93010987b3412
      
https://github.com/qemu/qemu/commit/5a358b39f52a28a84b380c1685c93010987b3412
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M hw/display/qxl.c
    M include/qemu/compiler.h

  Log Message:
  -----------
  hw/display/qxl: Suppress clang-7 warning about misaligned atomic operation

If QEMU is compiled with clang-7 it results in the warning:

hw/display/qxl.c:1884:19: error: misaligned or large atomic operation
may incur significant performance penalty [-Werror,-Watomic-alignment]
    old_pending = atomic_fetch_or(&d->ram->int_pending, le_events);
            ^

This is because the Spice headers forgot to define the QXLRam struct
with the '__aligned__(4)' attribute.  clang 7 and newer will thus
warn that the access here to int_pending might not be 4-aligned
(because the QXLRam object d->ram points at might start at a
misaligned address).  In fact we set up d->ram in init_qxl_ram() so
it always starts at a 4K boundary, so we know the atomic access here
is OK.

Newer Spice versions (with Spice commit
beda5ec7a6848be20c0cac2a9a8ef2a41e8069c1) will fix the bug;
for older Spice versions, work around it by telling the compiler
explicitly that the alignment is OK using __builtin_assume_aligned().

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 0ab90e617040e5590f7fc403b5d34f76f53f6bdc
      
https://github.com/qemu/qemu/commit/0ab90e617040e5590f7fc403b5d34f76f53f6bdc
  Author: remy.noel <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M hw/display/vga-pci.c

  Log Message:
  -----------
  secondary-vga: delete mmio subregions upon exit

93abfc88bd649de1933588bfc7175605331b3ea9 introduced a reference cycle in
the vga-pci devices, preventing cleanup of the object upon hotblug.

This patch allows to break the cycle.

Signed-off-by: remy.noel <address@hidden>
Message-id: address@hidden

[ kraxel: delete the recently added edid region too ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: edbc4b24bbb179fa9562d4e5313470f10569433c
      
https://github.com/qemu/qemu/commit/edbc4b24bbb179fa9562d4e5313470f10569433c
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M hw/display/edid-generate.c
    M include/hw/display/edid.h

  Log Message:
  -----------
  edid: fix vendor default

"EMU" actually is "Emulex Corporation", so not a good idea to use that
by default.  Lets use the Red Hat vendor id instead, which is in line
with the pci ids which are allocated from Red Hat vendor ids too.

Vendor list is available from http://www.uefi.org/pnp_id_list

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: e2e3436add538be0e558cdc42f3e6b76e9deb0f9
      
https://github.com/qemu/qemu/commit/e2e3436add538be0e558cdc42f3e6b76e9deb0f9
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M .gitignore
    M hw/display/edid-generate.c
    M hw/display/qxl.c
    M hw/display/vga-pci.c
    M include/hw/display/edid.h
    M include/qemu/compiler.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20181005-pull-request' 
into staging

vga: edid fixes, qxl clang workaround, vga mmio subregion fix.

# gpg: Signature made Fri 05 Oct 2018 12:11:40 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20181005-pull-request:
  edid: fix vendor default
  secondary-vga: delete mmio subregions upon exit
  hw/display/qxl: Suppress clang-7 warning about misaligned atomic operation
  edid: Ignore built binary

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/3c2d30428496...e2e3436add53
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]