[Qemu-commits] [qemu/qemu] a1c0f8: vfio/pci: Handle subsystem realpath() returning NU...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a1c0f886496cfb4c336f8eb4155ed424567d653e
      
https://github.com/qemu/qemu/commit/a1c0f886496cfb4c336f8eb4155ed424567d653e
  Author: Alex Williamson <address@hidden>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio/pci: Handle subsystem realpath() returning NULL

Fix error reported by Coverity where realpath can return NULL,
resulting in a segfault in strcmp().  This should never happen given
that we're working through regularly structured sysfs paths, but
trivial enough to easily avoid.

Fixes: 238e91728503 ("vfio/ccw/pci: Allow devices to opt-in for ballooning")
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 8709b3954d4161bad30ccc435408ec50e10f53cc
      
https://github.com/qemu/qemu/commit/8709b3954d4161bad30ccc435408ec50e10f53cc
  Author: Alex Williamson <address@hidden>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M hw/vfio/common.c

  Log Message:
  -----------
  vfio/pci: Fix failure to close file descriptor on error

A new error path fails to close the device file descriptor when
triggered by a ballooning incompatibility within the group.  Fix it.

Fixes: 238e91728503 ("vfio/ccw/pci: Allow devices to opt-in for ballooning")
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 154304cd6e99e4222ed762976f9d9aca33c094d3
      
https://github.com/qemu/qemu/commit/154304cd6e99e4222ed762976f9d9aca33c094d3
  Author: Alex Williamson <address@hidden>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M migration/postcopy-ram.c

  Log Message:
  -----------
  postcopy: Synchronize usage of the balloon inhibitor

While the qemu_balloon_inhibit() interface appears rather general purpose,
postcopy uses it in a last-caller-wins approach with no guarantee of balanced
inhibits and de-inhibits.  Wrap postcopy's usage of the inhibitor to give it
one vote overall, using the same last-caller-wins approach as previously
implemented at the balloon level.

Fixes: 01ccbec7bdf6 ("balloon: Allow multiple inhibit users")
Reported-by: Christian Borntraeger <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 17182bb47fe62ac6a005b325a7007488056f3a2d
      
https://github.com/qemu/qemu/commit/17182bb47fe62ac6a005b325a7007488056f3a2d
  Author: Peter Maydell <address@hidden>
  Date:   2018-08-25 (Sat, 25 Aug 2018)

  Changed paths:
    M hw/vfio/common.c
    M hw/vfio/pci.c
    M migration/postcopy-ram.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20180823.1' 
into staging

VFIO fixes 2018-08-23

 - Fix coverity reported issue with use of realpath (Alex Williamson)

 - Cleanup file descriptor in error path (Alex Williamson)

 - Fix postcopy use of new balloon inhibitor (Alex Williamson)

# gpg: Signature made Thu 23 Aug 2018 17:46:41 BST
# gpg:                using RSA key 239B9B6E3BB08B22
# gpg: Good signature from "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B  8A90 239B 9B6E 3BB0 8B22

* remotes/awilliam/tags/vfio-fixes-20180823.1:
  postcopy: Synchronize usage of the balloon inhibitor
  vfio/pci: Fix failure to close file descriptor on error
  vfio/pci: Handle subsystem realpath() returning NULL

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/cc9821fa9ac4...17182bb47fe6
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.