qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1d3498: tcg: fix s/compliment/complement/ typ


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 1d3498: tcg: fix s/compliment/complement/ typos
Date: Mon, 21 May 2018 05:21:58 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1d349821551c2da4dfefe36c6ac17319f33ebbd5
      
https://github.com/qemu/qemu/commit/1d349821551c2da4dfefe36c6ac17319f33ebbd5
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M target/i386/translate.c
    M target/m68k/translate.c
    M tcg/README

  Log Message:
  -----------
  tcg: fix s/compliment/complement/ typos

Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 787bbc306e2770c73f9fd9d3a209d26af191e352
      
https://github.com/qemu/qemu/commit/787bbc306e2770c73f9fd9d3a209d26af191e352
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M hw/ide/trace-events
    M hw/misc/trace-events

  Log Message:
  -----------
  misc, ide: remove use of HWADDR_PRIx in trace events

The trace events all use a uint64_t data type, so should be using the
corresponding PRIx64 format, not HWADDR_PRIx which is intended for use
with the 'hwaddr' type.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3ad9319f5cf560567ae75c2d94614e979409d580
      
https://github.com/qemu/qemu/commit/3ad9319f5cf560567ae75c2d94614e979409d580
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M slirp/arp_table.c
    M slirp/socket.c
    M slirp/udp.c

  Log Message:
  -----------
  slirp/debug: Print IP addresses in human readable form

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 0b816e986dd5b39ff5dfacd6c74e012b3b4c09e1
      
https://github.com/qemu/qemu/commit/0b816e986dd5b39ff5dfacd6c74e012b3b4c09e1
  Author: Michael Tokarev <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qemu-option-trace.texi

  Log Message:
  -----------
  qemu-option-trace: -trace enable= is a pattern, not a file

Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f7c922ed3d8e3cb54febbdc594ce9f4400e0d290
      
https://github.com/qemu/qemu/commit/f7c922ed3d8e3cb54febbdc594ce9f4400e0d290
  Author: Murilo Opsfelder Araujo <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M HACKING

  Log Message:
  -----------
  HACKING: document preference for g_new instead of g_malloc

This patch documents the preference for g_new instead of g_malloc. The
reasons were adapted from commit b45c03f585ea9bb1af76c73e82195418c294919d.

Discussion in QEMU's mailing list:
  http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg03238.html

Cc: address@hidden
Cc: David Hildenbrand <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Murilo Opsfelder Araujo <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 65f389c0e7f6660e1acbd93e2ad23ce7172324bf
      
https://github.com/qemu/qemu/commit/65f389c0e7f6660e1acbd93e2ad23ce7172324bf
  Author: John Snow <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qemu-img-cmds.hx

  Log Message:
  -----------
  qemu-img-commands.hx: argument ordering fixups

The TEXI and string versions are actually identical, except for markup.
We can probably automate this... but make the ordering the same until
then.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 83e6da02b6bd3401fd6e5ea57915b84144465740
      
https://github.com/qemu/qemu/commit/83e6da02b6bd3401fd6e5ea57915b84144465740
  Author: John Snow <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qemu-img.texi

  Log Message:
  -----------
  qemu-img.texi: fix command ordering

This should match the summary ordering, which is alphabetical.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 183861456d5e01649df9591a535486c10d72e060
      
https://github.com/qemu/qemu/commit/183861456d5e01649df9591a535486c10d72e060
  Author: John Snow <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qemu-img.c
    M qemu-options-wrapper.h

  Log Message:
  -----------
  qemu-img: remove references to GEN_DOCS

Nothing seemingly uses this.
(jcody: commit 77bd1119ba even mentions that it appears unused)

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 9775fcdb11ab425cc3537ebe95dcf818bedfc954
      
https://github.com/qemu/qemu/commit/9775fcdb11ab425cc3537ebe95dcf818bedfc954
  Author: John Snow <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qemu-img-cmds.hx
    M qemu-img.texi

  Log Message:
  -----------
  qemu-img: Make documentation between .texi and .hx consistent

These are also different and out of order for whatever reason.
I'd like to automate this in the future, but for now let's put
on the band-aid.

In the case of resize, there were options missing from all
three docstrings; the new string is based on the code.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 4885b0caf607579a0f99c221fa39ca97d9a6ddf4
      
https://github.com/qemu/qemu/commit/4885b0caf607579a0f99c221fa39ca97d9a6ddf4
  Author: John Snow <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qemu-img-cmds.hx

  Log Message:
  -----------
  qemu-img-cmds.hx: add passive-aggressive note

I'm kidding. It's very easy to forget there are per-command sections
in the texi, and insane that we don't autogenerate those, too.

Until then, leave a little post-it note in this .hx file until I
find a way to delete it.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6b1875476313ce320a6a1d1827e85511365a469c
      
https://github.com/qemu/qemu/commit/6b1875476313ce320a6a1d1827e85511365a469c
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M hw/ide/ahci-allwinner.c
    M hw/ide/ahci_internal.h

  Log Message:
  -----------
  hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal

The ALLWINNER_AHCI() macro is only used in ahci-allwinner.c.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 7647d5c6b5e3b3f36a6e0441c81ae3fe797eb233
      
https://github.com/qemu/qemu/commit/7647d5c6b5e3b3f36a6e0441c81ae3fe797eb233
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M tests/tpm-emu.c

  Log Message:
  -----------
  tests: fix tpm-crb tpm-tis tests race

No need to close the TPM data socket on the emulator end, qemu will
close it after a SHUTDOWN. This avoids a race between close() and
read() in the TPM data thread.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f23c81073a4f9aa41a3687161f6ca3d66501a280
      
https://github.com/qemu/qemu/commit/f23c81073a4f9aa41a3687161f6ca3d66501a280
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M include/hw/ppc/ppc4xx.h
    M include/hw/virtio/virtio-balloon.h
    M include/hw/virtio/virtio-gpu.h

  Log Message:
  -----------
  trivial: Do not include pci.h if it is not necessary

There is no need to include pci.h in these files.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 4a4ff4c58fd750cde01c8b15d30d038cefc90a42
      
https://github.com/qemu/qemu/commit/4a4ff4c58fd750cde01c8b15d30d038cefc90a42
  Author: Laurent Vivier <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M accel/tcg/translate-all.c
    M block/quorum.c
    M hw/arm/exynos4210.c
    M hw/block/vhost-user-blk.c
    M hw/hppa/dino.c
    M hw/misc/mos6522.c
    M hw/net/ftgmac100.c
    M hw/ppc/pnv_lpc.c
    M io/net-listener.c
    M target/i386/hax-darwin.c
    M target/mips/dsp_helper.c
    M target/xtensa/core-dc232b/xtensa-modules.inc.c
    M target/xtensa/core-dc233c/xtensa-modules.inc.c
    M target/xtensa/core-de212/xtensa-modules.inc.c
    M target/xtensa/core-fsf/xtensa-modules.inc.c
    M target/xtensa/core-sample_controller/xtensa-modules.inc.c
    M target/xtensa/translate.c
    M tests/m48t59-test.c
    M tests/test-thread-pool.c
    M util/uri.c

  Log Message:
  -----------
  Remove unnecessary variables for function return value

Re-run Coccinelle script scripts/coccinelle/return_directly.cocci

Signed-off-by: Laurent Vivier <address@hidden>
ppc part
Acked-by: David Gibson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 54be4c42b2796ca6054cd1539d3ad4486447c789
      
https://github.com/qemu/qemu/commit/54be4c42b2796ca6054cd1539d3ad4486447c789
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M hw/timer/m48t59-internal.h
    M hw/timer/m48t59.c

  Log Message:
  -----------
  hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

When compiling with NVRAM_PRINTF enabled, gcc currently bails out with:

  CC      hw/timer/m48t59.o
  CC      hw/timer/m48t59-isa.o
hw/timer/m48t59.c: In function ‘NVRAM_writeb’:
hw/timer/m48t59.c:460:5: error: format ‘%x’ expects argument of type ‘unsigned 
int’, but argument 3 has type ‘hwaddr’ [-Werror=format=]
     NVRAM_PRINTF("%s: 0x%08x => 0x%08x\n", __func__, addr, val);
     ^
hw/timer/m48t59.c:460:5: error: format ‘%x’ expects argument of type ‘unsigned 
int’, but argument 4 has type ‘uint64_t’ [-Werror=format=]
hw/timer/m48t59.c: In function ‘NVRAM_readb’:
hw/timer/m48t59.c:492:5: error: format ‘%x’ expects argument of type ‘unsigned 
int’, but argument 3 has type ‘hwaddr’ [-Werror=format=]
     NVRAM_PRINTF("%s: 0x%08x <= 0x%08x\n", __func__, addr, retval);

Fix it by using the correct format strings and while we're at it,
also change the definition of NVRAM_PRINTF so that this can not
bit-rot so easily again.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: aec0d0e11812c602866c9fa044847f1e7b1e7dff
      
https://github.com/qemu/qemu/commit/aec0d0e11812c602866c9fa044847f1e7b1e7dff
  Author: Michal Privoznik <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  qemu-options: Allow -no-user-config again

After 1217d6ca2bf28c0febe1bd7d5b3fa912bbf6af2a we error out
explicitly if an unknown -option was passed on the command line.
However, we are doing two pass command line option parsing. In
the first pass we just look for -no-user-config or -nodefconfig
being present which determines whether we load user config or
not. Then in the second pass we finally parse everything else
throwing an error if an unsupported -option was found. Problem is
that in the second pass -no-user-config and -nodefconfig are not
handled explicitly which makes us throw the unsupported option
error.

Signed-off-by: Michal Privoznik <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 201376cb9e500f64209444cb95f566679c0f54a2
      
https://github.com/qemu/qemu/commit/201376cb9e500f64209444cb95f566679c0f54a2
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M include/qemu/typedefs.h

  Log Message:
  -----------
  typedefs: Remove PcGuestInfo from qemu/typedefs.h

It is long gone since e4e8ba04c2007 ...

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d29eb678bcfbb2fbf4b79423797253ee02f5c6cf
      
https://github.com/qemu/qemu/commit/d29eb678bcfbb2fbf4b79423797253ee02f5c6cf
  Author: Olaf Hering <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M util/vfio-helpers.c

  Log Message:
  -----------
  replace functions which are only available in glib-2.24

Currently the minimal supported version of glib is 2.22.
Since testing is done with a glib that claims to be 2.22, but in fact
has APIs from newer version of glib, this bug was not caught during
submit of the patch referenced below.

Replace g_realloc_n, which is available only since 2.24, with g_renew.

Fixes commit 418026ca43 ("util: Introduce vfio helpers")

Signed-off-by: Olaf Hering <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
CC: address@hidden


  Commit: f5bdd781316d2ba140323cb98392e44cac54017d
      
https://github.com/qemu/qemu/commit/f5bdd781316d2ba140323cb98392e44cac54017d
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: Use qemu_set_cloexec()

Use the utility routine qemu_set_cloexec() rather than
manually calling fcntl(). This lets us drop the #ifndef _WIN32
guards and also means Coverity doesn't complain that we're
ignoring the fcntl error return (CID 1005665, CID 1005667).

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2f652224f76c115f6c991766b7acac1e22580954
      
https://github.com/qemu/qemu/commit/2f652224f76c115f6c991766b7acac1e22580954
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: Handle errors in gdb_accept()

In gdb_accept(), we both fail to check all errors (notably
that from socket_set_nodelay(), as Coverity notes in CID 1005666),
and fail to return an error status back to our caller. Correct
both of these things, so that errors in accept() result in our
stopping with a useful error message rather than ignoring it.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 4088b5536436090207dcf6d15e47908f74b2d8f2
      
https://github.com/qemu/qemu/commit/4088b5536436090207dcf6d15e47908f74b2d8f2
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M qapi/net.json

  Log Message:
  -----------
  qapi/net.json: Fix the version number of the "vlan" removal

"vlan" will be dropped in 2.13, not in 2.12. And while we're at it,
use the better wording "dropped in" instead of "removed with" (also
for the "dump" removal).

Reported-by: Stefan Hajnoczi <address@hidden>
Reported-by: Eric Blake <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 9a232487aab8a7640ff8853d7d8d7c27106b44f8
      
https://github.com/qemu/qemu/commit/9a232487aab8a7640ff8853d7d8d7c27106b44f8
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-05-20 (Sun, 20 May 2018)

  Changed paths:
    M hw/acpi/aml-build.c

  Log Message:
  -----------
  acpi: fix a comment about aml_call0()

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 9802316ed6c19fd45b4c498523df02ca370d0586
      
https://github.com/qemu/qemu/commit/9802316ed6c19fd45b4c498523df02ca370d0586
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-21 (Mon, 21 May 2018)

  Changed paths:
    M HACKING
    M accel/tcg/translate-all.c
    M block/quorum.c
    M gdbstub.c
    M hw/acpi/aml-build.c
    M hw/arm/exynos4210.c
    M hw/block/vhost-user-blk.c
    M hw/hppa/dino.c
    M hw/ide/ahci-allwinner.c
    M hw/ide/ahci_internal.h
    M hw/ide/trace-events
    M hw/misc/mos6522.c
    M hw/misc/trace-events
    M hw/net/ftgmac100.c
    M hw/ppc/pnv_lpc.c
    M hw/timer/m48t59-internal.h
    M hw/timer/m48t59.c
    M include/hw/ppc/ppc4xx.h
    M include/hw/virtio/virtio-balloon.h
    M include/hw/virtio/virtio-gpu.h
    M include/qemu/typedefs.h
    M io/net-listener.c
    M qapi/net.json
    M qemu-img-cmds.hx
    M qemu-img.c
    M qemu-img.texi
    M qemu-option-trace.texi
    M qemu-options-wrapper.h
    M slirp/arp_table.c
    M slirp/socket.c
    M slirp/udp.c
    M target/i386/hax-darwin.c
    M target/i386/translate.c
    M target/m68k/translate.c
    M target/mips/dsp_helper.c
    M target/xtensa/core-dc232b/xtensa-modules.inc.c
    M target/xtensa/core-dc233c/xtensa-modules.inc.c
    M target/xtensa/core-de212/xtensa-modules.inc.c
    M target/xtensa/core-fsf/xtensa-modules.inc.c
    M target/xtensa/core-sample_controller/xtensa-modules.inc.c
    M target/xtensa/translate.c
    M tcg/README
    M tests/m48t59-test.c
    M tests/test-thread-pool.c
    M tests/tpm-emu.c
    M util/uri.c
    M util/vfio-helpers.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into 
staging

trivial patches for 2018-05-20

# gpg: Signature made Sun 20 May 2018 07:13:20 BST
# gpg:                using RSA key 701B4F6B1A693E59
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
#      Subkey fingerprint: 7B73 BAD6 8BE7 A2C2 8931  4B22 701B 4F6B 1A69 3E59

* remotes/mjt/tags/trivial-patches-fetch: (22 commits)
  acpi: fix a comment about aml_call0()
  qapi/net.json: Fix the version number of the "vlan" removal
  gdbstub: Handle errors in gdb_accept()
  gdbstub: Use qemu_set_cloexec()
  replace functions which are only available in glib-2.24
  typedefs: Remove PcGuestInfo from qemu/typedefs.h
  qemu-options: Allow -no-user-config again
  hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings
  Remove unnecessary variables for function return value
  trivial: Do not include pci.h if it is not necessary
  tests: fix tpm-crb tpm-tis tests race
  hw/ide/ahci: Keep ALLWINNER_AHCI() macro internal
  qemu-img-cmds.hx: add passive-aggressive note
  qemu-img: Make documentation between .texi and .hx consistent
  qemu-img: remove references to GEN_DOCS
  qemu-img.texi: fix command ordering
  qemu-img-commands.hx: argument ordering fixups
  HACKING: document preference for g_new instead of g_malloc
  qemu-option-trace: -trace enable= is a pattern, not a file
  slirp/debug: Print IP addresses in human readable form
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/dfa93a0b6ef5...9802316ed6c1
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]