[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] fb1a66: tracetool: Update argument format reg
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] fb1a66: tracetool: Update argument format regex to non-gre... |
Date: |
Mon, 19 Feb 2018 10:25:58 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: fb1a66bc01b6f7376b452a313538a472451a0ba4
https://github.com/qemu/qemu/commit/fb1a66bc01b6f7376b452a313538a472451a0ba4
Author: Jon Emil Jahren <address@hidden>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M scripts/tracetool/__init__.py
Log Message:
-----------
tracetool: Update argument format regex to non-greedy star
Using the greedy star matching, arguments like "...%"PRIx64 caused issues
for functions with multiple PRI formats.
The issue was only seen with the ust backend, as it is the only one
using the format regex.
The result for many functions was that the arguments coming after the
greedy star end was left out of the tracepoint, and in some cases some
of the arguments that was traced had the wrong format.
Signed-off-by: Jon Emil Jahren <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: 61b01bbc6c27f06f4732aedcb6554e135f41b760
https://github.com/qemu/qemu/commit/61b01bbc6c27f06f4732aedcb6554e135f41b760
Author: Jon Emil Jahren <address@hidden>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M scripts/tracetool/format/ust_events_h.py
Log Message:
-----------
tracetool: For ust trace bool type as ctf_integer
Previously functions having arguments of type bool was not traced
properly. The bool arguments were missing from the trace.
Signed-off-by: Jon Emil Jahren <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: 7f1d87ab0fd94cef5086e2879716958303281054
https://github.com/qemu/qemu/commit/7f1d87ab0fd94cef5086e2879716958303281054
Author: Stefan Hajnoczi <address@hidden>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M hw/block/trace-events
M trace-events
Log Message:
-----------
trace: avoid SystemTap "char const" warnings
SystemTap's dtrace(1) produces the following warning when it encounters
"char const" instead of "const char":
Warning: /usr/bin/dtrace:trace-dtrace-root.dtrace:66: syntax error near:
probe flatview_destroy_rcu
Warning: Proceeding as if --no-pyparsing was given.
This is a limitation in current SystemTap releases. I have sent a patch
upstream to accept "char const" since it is valid C:
https://sourceware.org/ml/systemtap/2018-q1/msg00017.html
In QEMU we still wish to avoid warnings in the current SystemTap
release. It's simple enough to replace "char const" with "const char".
I'm not changing the documentation or implementing checks to prevent
this from occurring again in the future. The next release of SystemTap
will hopefully resolve this issue.
Cc: Daniel P. Berrange <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Commit: afd3397a8149d8b645004e459bf2002d78f5e267
https://github.com/qemu/qemu/commit/afd3397a8149d8b645004e459bf2002d78f5e267
Author: Peter Maydell <address@hidden>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M hw/block/trace-events
M scripts/tracetool/__init__.py
M scripts/tracetool/format/ust_events_h.py
M trace-events
Log Message:
-----------
Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request'
into staging
# gpg: Signature made Mon 19 Feb 2018 16:19:46 GMT
# gpg: using RSA key 9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg: aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35 775A 9CA4 ABB3 81AB 73C8
* remotes/stefanha/tags/tracing-pull-request:
trace: avoid SystemTap "char const" warnings
tracetool: For ust trace bool type as ctf_integer
tracetool: Update argument format regex to non-greedy star
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/299a2e6fac39...afd3397a8149
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] fb1a66: tracetool: Update argument format regex to non-gre...,
GitHub <=