qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 8a37fc: tpm-tis: remove unused locty_number


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 8a37fc: tpm-tis: remove unused locty_number
Date: Sun, 17 Dec 2017 13:31:54 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8a37fc44c6618ca0ede761809d0ecaf605f832fc
      
https://github.com/qemu/qemu/commit/8a37fc44c6618ca0ede761809d0ecaf605f832fc
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: remove unused locty_number

This field slipped in commit 5086bf9784.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 67af320cd653a107c0bbdf0d2e6c51b24403c64d
      
https://github.com/qemu/qemu/commit/67af320cd653a107c0bbdf0d2e6c51b24403c64d
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_int.h
    M include/sysemu/tpm.h

  Log Message:
  -----------
  tpm: move TpmIf in include/sysemu/tpm.h

This is a better location than hw/tpm, since we are going to use the
interface from outside hw/tpm.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 8a89c9ac15981c2d15ce4ee6d6ad67da58824a04
      
https://github.com/qemu/qemu/commit/8a89c9ac15981c2d15ce4ee6d6ad67da58824a04
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm.h
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm-backend: store TPMIf interface, improve backend_init()

Store the TPM interface, the actual object may be different from
TPMState. Keep a reference on the interface, and check the backend
wasn't already initialized.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 36e8658924cec6427ca00f87ce86f65cfa705d69
      
https://github.com/qemu/qemu/commit/36e8658924cec6427ca00f87ce86f65cfa705d69
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm.h

  Log Message:
  -----------
  tpm-tis: no longer expose TPMState

Now that there is an interface instead.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 689990598a710519eba37e4eb4d8bdebac1aa562
      
https://github.com/qemu/qemu/commit/689990598a710519eba37e4eb4d8bdebac1aa562
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm.h
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm-be: call request_completed() out of thread

Lift from the backend implementation the responsability to call the
request_completed() callback outside of thread context. This also
simplify frontend/interface work, as they no longer need to care
whether the callback is called from a different thread.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 0bd6c8a9cfa4fd5c25a32ed39f3b8cb786b75b58
      
https://github.com/qemu/qemu/commit/0bd6c8a9cfa4fd5c25a32ed39f3b8cb786b75b58
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm-be: report error instead of front-end

Backend can give more accurate error description, and lift out the job
from the frontend.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 191adc9476371ad94771609d8b9a968d9332a962
      
https://github.com/qemu/qemu/commit/191adc9476371ad94771609d8b9a968d9332a962
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm.h
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm-be: ask model to the TPM interface

No need to store the mode in the backend, or to let the frontend set
it itself.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 3c3ef630621e4cdc5171dcfd19a22b2dc300bcb3
      
https://github.com/qemu/qemu/commit/3c3ef630621e4cdc5171dcfd19a22b2dc300bcb3
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm: remove unused opened code

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 69c07db04625cb243db6e8a0ac0a8e3973dd961a
      
https://github.com/qemu/qemu/commit/69c07db04625cb243db6e8a0ac0a8e3973dd961a
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm-passthrough: don't save guessed cancel_path in options

The value is later unneeded, and may leak if the free visitor doesn't
consider it since has_cancel_path is false. And for consistency with
"path" it shouldn't be returned in get_tpm_options().

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: ebca2df783a5a742bb93784524336d8cbb9e662b
      
https://github.com/qemu/qemu/commit/ebca2df783a5a742bb93784524336d8cbb9e662b
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm-be: update optional function pointers

QEMU code doesn't generally have assert() for mandatory
callbacks/function pointers, probably because the crash is pretty
obvious. Document the methods instead of going into the code.

Make get_tpm_options() mandatory to implement (since all
backend implementation have it).

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 803de211aa1447585b91354aa2ae8dddd4ff68e0
      
https://github.com/qemu/qemu/commit/803de211aa1447585b91354aa2ae8dddd4ff68e0
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm-passthrough: pass TPMPassthruState to handle_device_opts

It doesn't need TPMBackend. Also reorder arguments for consistency.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 9f7c0ef2ffa02b3bf6bc630496b8df67c750edd3
      
https://github.com/qemu/qemu/commit/9f7c0ef2ffa02b3bf6bc630496b8df67c750edd3
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm-backend: move set 'id' to common code

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 8df4d8484f607d4973e66e93f2eba0b3f80c4238
      
https://github.com/qemu/qemu/commit/8df4d8484f607d4973e66e93f2eba0b3f80c4238
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm-passthrough: make it safer to destroy after creation

Check fds values before closing, to avoid close(-1).

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: bef2ed3fd2454586a7c1132ad574b891741d12c6
      
https://github.com/qemu/qemu/commit/bef2ed3fd2454586a7c1132ad574b891741d12c6
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm-passthrough: simplify create()

Use a similar code as tpm_emulator_create(), call handle_opts() and
handle failure cleanup with object_unref() in create().

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 21cb1e63a594e36ff350fba41600190fb0a1f42b
      
https://github.com/qemu/qemu/commit/21cb1e63a594e36ff350fba41600190fb0a1f42b
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm-passthrough: workaround a possible race

The TPM backend processing thread has common shared variable race
issues. (they should not be so easy to reach since guest interaction
with the device is slow compared to host emulation)

An obvious one is setting op_cancelled from device thread after
calling write(cancel_fd). The backend thread may return before the
device thread has set the variable. Instead set it before
cancellation. Even if the write() failed, the end result is command
get possibly cancelled (even if cancellation came from external
sources it doesn't matter much).

It's worth to consider removing the backend processing thread for now.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 023299d87f7b6cccaede8210755afd0c2eaec41a
      
https://github.com/qemu/qemu/commit/023299d87f7b6cccaede8210755afd0c2eaec41a
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: simplify header inclusion

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d36e7db1fbf1a5cff4aa359dfe5c2e5dd97d3e13
      
https://github.com/qemu/qemu/commit/d36e7db1fbf1a5cff4aa359dfe5c2e5dd97d3e13
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm: rename qemu_find_tpm() -> qemu_find_tpm_be()

find_tpm() will be introduced to lookup the TPM device.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 3dfd5a2a50fc4907728eb83569c84b0d98b56582
      
https://github.com/qemu/qemu/commit/3dfd5a2a50fc4907728eb83569c84b0d98b56582
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/i386/acpi-build.c
    M include/sysemu/tpm.h

  Log Message:
  -----------
  tpm: lookup the the TPM interface instead of TIS device

This will allow to introduce new devices implementing TPM.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 9af7a721662de8cdfa7b02b7e9cc2c2c30e7bacb
      
https://github.com/qemu/qemu/commit/9af7a721662de8cdfa7b02b7e9cc2c2c30e7bacb
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm.h

  Log Message:
  -----------
  tpm: add TPM interface to lookup TPM version

Do not hardcode TPM device model to lookup version, use an interface
instead.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 5cf954d02161a974c16b33189192b43da9ac4413
      
https://github.com/qemu/qemu/commit/5cf954d02161a974c16b33189192b43da9ac4413
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c
    M hw/tpm/tpm_util.h

  Log Message:
  -----------
  tpm: add tpm_cmd_get_size() to tpm_util

The function is generally useful and used in the following patches.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: ff5ce21e1b959206f257967d6de2efa6f4e3d188
      
https://github.com/qemu/qemu/commit/ff5ce21e1b959206f257967d6de2efa6f4e3d188
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/i386/acpi-build.c
    M include/sysemu/tpm.h

  Log Message:
  -----------
  acpi: change TPM TIS data conditions

The device should be exposed if present. It shouldn't have an
undefined version (or else backend init failed, and device should fail
too). Finally, make the fields specific to TIS device model.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 3d01141144583bd12b5d7c76326328e509a677ec
      
https://github.com/qemu/qemu/commit/3d01141144583bd12b5d7c76326328e509a677ec
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_emulator.c

  Log Message:
  -----------
  tpm-emulator: add a FIXME comment about blocking cancel

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: c87b35fa71833ec4c34fb4a85f03c47028c44d0e
      
https://github.com/qemu/qemu/commit/c87b35fa71833ec4c34fb4a85f03c47028c44d0e
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: remove redundant 'tpm_tis:' in error messages

The reported error message is already prefixed with the -device
name & arguments.

Before:
qemu-system-x86_64: -device tpm-tis,id=foo,tpmdev=foo,irq=21: tpm_tis: IRQ 21 
is outside valid range of 0 to 15

After:
qemu-system-x86_64: -device tpm-tis,id=foo,tpmdev=foo,irq=21: IRQ 21 is outside 
valid range of 0 to 15

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 51a837e908d6f4bbe94469a4a0edcb76348fe964
      
https://github.com/qemu/qemu/commit/51a837e908d6f4bbe94469a4a0edcb76348fe964
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: check that at most one TPM device exists

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 493b78303532146c8161b33e878db8af7dca3b81
      
https://github.com/qemu/qemu/commit/493b78303532146c8161b33e878db8af7dca3b81
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/core/qdev-properties-system.c
    M include/hw/qdev-properties.h

  Log Message:
  -----------
  qdev: add DEFINE_PROP_TPMBE

A property to lookup a tpm backend.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: c03785440d1d949cad6fa515e456479c2ec9b212
      
https://github.com/qemu/qemu/commit/c03785440d1d949cad6fa515e456479c2ec9b212
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c

  Log Message:
  -----------
  tpm-tis: use DEFINE_PROP_TPMBE

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: d3fd953f06700ebe2d15825d4399f7cd3e31af34
      
https://github.com/qemu/qemu/commit/d3fd953f06700ebe2d15825d4399f7cd3e31af34
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  tpm: remove tpm_register_model()

Query object classes that implements TPMIf instead.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: b21e6aaf4a1e25c22a603e22ef96b3a31d3013aa
      
https://github.com/qemu/qemu/commit/b21e6aaf4a1e25c22a603e22ef96b3a31d3013aa
  Author: Stefan Berger <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: Move getting TPM buffer size to backends

Rather than setting the size of the TPM buffer in the front-end,
query the backend for the size of the buffer. In this patch we
just move the hard-coded buffer size of 4096 to the backends.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 56388eee01144d59d5c94a34431a29c75073ba53
      
https://github.com/qemu/qemu/commit/56388eee01144d59d5c94a34431a29c75073ba53
  Author: Stefan Berger <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_util.c

  Log Message:
  -----------
  tpm: pull tpm_util_request() out of tpm_util_test()

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: abc5cda097f46bdb86833a38ee0961a0e6a47ae1
      
https://github.com/qemu/qemu/commit/abc5cda097f46bdb86833a38ee0961a0e6a47ae1
  Author: Stefan Berger <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_util.c
    M hw/tpm/tpm_util.h

  Log Message:
  -----------
  tpm: tpm_passthrough: Read the buffer size from the host device

Rather than hard coding the buffer size in the tpm_passthrough
backend read the TPM I/O buffer size from the host device.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 9375c44fdfc07c0fef3052a3f25a13197a528902
      
https://github.com/qemu/qemu/commit/9375c44fdfc07c0fef3052a3f25a13197a528902
  Author: Stefan Berger <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_ioctl.h
    M hw/tpm/tpm_tis.c
    M include/sysemu/tpm_backend.h

  Log Message:
  -----------
  tpm: tpm_emulator: get and set buffer size of device

Convert the tpm_emulator backend to get the current buffer size
of the external device and set it to the buffer size that the
frontend (TIS) requests.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 683c4b775355cc7acd301e8efe7d4c1c9acdafd8
      
https://github.com/qemu/qemu/commit/683c4b775355cc7acd301e8efe7d4c1c9acdafd8
  Author: Stefan Berger <address@hidden>
  Date:   2017-12-14 (Thu, 14 Dec 2017)

  Changed paths:
    M hw/tpm/tpm_passthrough.c

  Log Message:
  -----------
  tpm: tpm_passthrough: Fail startup if FE buffer size < BE buffer size

If the requested buffer size of the frontend is smaller than the fixed
buffer size of the host's TPM, fail the startup_tpm() interface function,
which will make the device unusable. We fail it because the backend TPM
could produce larger packets than what the frontend could pass to the OS.

The current combination of TIS frontend and either passthrough or emulator
backend will not lead to this case since the TIS can support any size of
buffer.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 411ad78115ebeb3411cf4b7622784b93dfabe259
      
https://github.com/qemu/qemu/commit/411ad78115ebeb3411cf4b7622784b93dfabe259
  Author: Peter Maydell <address@hidden>
  Date:   2017-12-17 (Sun, 17 Dec 2017)

  Changed paths:
    M backends/tpm.c
    M hw/core/qdev-properties-system.c
    M hw/i386/acpi-build.c
    M hw/tpm/tpm_emulator.c
    M hw/tpm/tpm_int.h
    M hw/tpm/tpm_ioctl.h
    M hw/tpm/tpm_passthrough.c
    M hw/tpm/tpm_tis.c
    M hw/tpm/tpm_util.c
    M hw/tpm/tpm_util.h
    M include/hw/qdev-properties.h
    M include/sysemu/tpm.h
    M include/sysemu/tpm_backend.h
    M tpm.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging

Merge tpm 2017/12/15 v1

# gpg: Signature made Fri 15 Dec 2017 04:44:15 GMT
# gpg:                using RSA key 0x75AD65802A0B4211
# gpg: Good signature from "Stefan Berger <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: B818 B9CA DF90 89C2 D5CE  C66B 75AD 6580 2A0B 4211

* remotes/stefanberger/tags/pull-tpm-2017-12-15-1: (32 commits)
  tpm: tpm_passthrough: Fail startup if FE buffer size < BE buffer size
  tpm: tpm_emulator: get and set buffer size of device
  tpm: tpm_passthrough: Read the buffer size from the host device
  tpm: pull tpm_util_request() out of tpm_util_test()
  tpm: Move getting TPM buffer size to backends
  tpm: remove tpm_register_model()
  tpm-tis: use DEFINE_PROP_TPMBE
  qdev: add DEFINE_PROP_TPMBE
  tpm-tis: check that at most one TPM device exists
  tpm-tis: remove redundant 'tpm_tis:' in error messages
  tpm-emulator: add a FIXME comment about blocking cancel
  acpi: change TPM TIS data conditions
  tpm: add tpm_cmd_get_size() to tpm_util
  tpm: add TPM interface to lookup TPM version
  tpm: lookup the the TPM interface instead of TIS device
  tpm: rename qemu_find_tpm() -> qemu_find_tpm_be()
  tpm-tis: simplify header inclusion
  tpm-passthrough: workaround a possible race
  tpm-passthrough: simplify create()
  tpm-passthrough: make it safer to destroy after creation
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/38d1b31e0501...411ad78115eb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]