[Qemu-commits] [qemu/qemu] 53d6e5: arm: remove remaining cannot_destroy_with_object_f...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 53d6e53189334fd0905e0a7c4bd9156d6a0d17fb
      
https://github.com/qemu/qemu/commit/53d6e53189334fd0905e0a7c4bd9156d6a0d17fb
  Author: Laurent Vivier <address@hidden>
  Date:   2017-04-20 (Thu, 20 Apr 2017)

  Changed paths:
    M hw/arm/allwinner-a10.c
    M hw/arm/bcm2836.c
    M hw/arm/digic.c
    M hw/arm/fsl-imx25.c
    M hw/arm/fsl-imx31.c
    M hw/arm/fsl-imx6.c
    M hw/arm/xlnx-zynqmp.c

  Log Message:
  -----------
  arm: remove remaining cannot_destroy_with_object_finalize_yet

With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to
realize functions"), we can now remove all the
remaining cannot_destroy_with_object_finalize_yet as
unsafe references have been moved to cpu_exec_realizefn().
(tested with QOM command provided by commit 4c315c27).

Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Acked-by: Alistair Francis <address@hidden>
Acked-by: Peter Maydell <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 40fda982f2e887f7d5cc36b8a7e3b5a07a1e6704
      
https://github.com/qemu/qemu/commit/40fda982f2e887f7d5cc36b8a7e3b5a07a1e6704
  Author: Laurent Vivier <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M target/ppc/kvm.c

  Log Message:
  -----------
  ppc: remove cannot_destroy_with_object_finalize_yet

This removes the assert(kvm_enabled()) from kvmppc_host_cpu_initfn()

This assert can never be triggered as the function is only registered
when KVM is available (see also 4c315c2
"qdev: Protect device-list-properties against broken devices").

So we can remove the cannot_destroy_with_object_finalize_yet from
kvmppc_host_cpu_class_init() without fear and beyond reproach.
(as it has already be done for i386 with 771a13e "i386: Unset
cannot_destroy_with_object_finalize_yet on "host" model" and
e435601 "target-i386: Remove assert(kvm_enabled()) from
host_x86_cpu_initfn()")

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Acked-by: Peter Maydell <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: d28fca153bb27ff965b9eb26d73327fa4d2402c8
      
https://github.com/qemu/qemu/commit/d28fca153bb27ff965b9eb26d73327fa4d2402c8
  Author: Laurent Vivier <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hw/pci-host/versatile.c

  Log Message:
  -----------
  versatile: remove cannot_destroy_with_object_finalize_yet

cannot_destroy_with_object_finalize_yet was added by 4c315c2
("qdev: Protect device-list-properties against broken devices")
because "realview_pci" and "versatile_pci" were hanging
during "device-list-properties" cleanup (an infinite loop in
bus_unparent()).

We have this problem because the child is not removed from
the list of the PCI bus children because it has no defined parent:
qdev_set_parent_bus() set the device parent_bus pointer to bus, and
adds the device in the bus children list, but doesn't update the
device parent pointer.

To fix the problem, move all the involved parts to the realize function.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Acked-by: Peter Maydell <address@hidden>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 08f00df4f4b8b4e38ad620477cc90cf5f73832d9
      
https://github.com/qemu/qemu/commit/08f00df4f4b8b4e38ad620477cc90cf5f73832d9
  Author: Laurent Vivier <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/hw/qdev-core.h
    M qmp.c

  Log Message:
  -----------
  qdev: remove cannot_destroy_with_object_finalize_yet

As all users have been removed, we can remove
cannot_destroy_with_object_finalize_yet field
from the DeviceClass structure.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Acked-by: Peter Maydell <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: bfec359afba088aaacc7d316f43302f28c6e642a
      
https://github.com/qemu/qemu/commit/bfec359afba088aaacc7d316f43302f28c6e642a
  Author: Peter Maydell <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hw/arm/allwinner-a10.c
    M hw/arm/bcm2836.c
    M hw/arm/digic.c
    M hw/arm/fsl-imx25.c
    M hw/arm/fsl-imx31.c
    M hw/arm/fsl-imx6.c
    M hw/arm/xlnx-zynqmp.c
    M hw/pci-host/versatile.c
    M include/hw/qdev-core.h
    M qmp.c
    M target/ppc/kvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qdev-2017-04-21' into 
staging

qdev patches for 2017-04-21

# gpg: Signature made Fri 21 Apr 2017 06:37:19 BST
# gpg:                using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qdev-2017-04-21:
  qdev: remove cannot_destroy_with_object_finalize_yet
  versatile: remove cannot_destroy_with_object_finalize_yet
  ppc: remove cannot_destroy_with_object_finalize_yet
  arm: remove remaining cannot_destroy_with_object_finalize_yet

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7cd37925a177...bfec359afba0