[Qemu-commits] [qemu/qemu] 53fabd: qemu-ga: obey LISTEN_PID when using systemd socket...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 53fabd4b86e15869e13fb762686d674c64294385
      
https://github.com/qemu/qemu/commit/53fabd4b86e15869e13fb762686d674c64294385
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-03-19 (Sun, 19 Mar 2017)

  Changed paths:
    A include/qemu/systemd.h
    M qemu-nbd.c
    M qga/main.c
    M util/Makefile.objs
    A util/systemd.c

  Log Message:
  -----------
  qemu-ga: obey LISTEN_PID when using systemd socket activation

qemu-ga's socket activation support was not obeying the LISTEN_PID
environment variable, which avoids that a process uses a socket-activation
file descriptor meant for its parent.

Mess can for example ensue if a process forks a children before consuming
the socket-activation file descriptor and therefore setting O_CLOEXEC
on it.

Luckily, qemu-nbd also got socket activation code, and its copy does
support LISTEN_PID.  Some extra fixups are needed to ensure that the
code can be used for both, but that's what this patch does.  The
main change is to replace get_listen_fds's "consume" argument with
the FIRST_SOCKET_ACTIVATION_FD macro from the qemu-nbd code.

Cc: "Richard W.M. Jones" <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 6b827cca9a781c486d42724b9462b65176588680
      
https://github.com/qemu/qemu/commit/6b827cca9a781c486d42724b9462b65176588680
  Author: Stefano Stabellini <address@hidden>
  Date:   2017-03-19 (Sun, 19 Mar 2017)

  Changed paths:
    M Makefile
    M hw/block/Makefile.objs
    M hw/char/Makefile.objs
    M hw/display/Makefile.objs
    M hw/net/Makefile.objs
    M hw/usb/Makefile.objs
    M hw/xen/Makefile.objs

  Log Message:
  -----------
  xen: do not build backends for targets that do not support xen

Change Makefile.objs to use CONFIG_XEN instead of CONFIG_XEN_BACKEND, so
that the Xen backends are only built for targets that support Xen.

Set CONFIG_XEN in the toplevel Makefile to ensure that files that are
built only once pick up Xen support properly.

Signed-off-by: Stefano Stabellini <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 732a802076635e9a5d56a9e37332e5c1836d43f2
      
https://github.com/qemu/qemu/commit/732a802076635e9a5d56a9e37332e5c1836d43f2
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-03-19 (Sun, 19 Mar 2017)

  Changed paths:
    M bsd-user/mmap.c
    M configure

  Log Message:
  -----------
  configure: remove Cygwin

The Cygwin target is really compiling for native Win32 with -mno-cygwin.
Except, GCC 4.7.0 has finally removed the long deprecated -mno-cygwin
option, and that happened about five years ago.

Let it rest in peace.

Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b3d3a426da9b067366bc132d53a6fa6b72675b55
      
https://github.com/qemu/qemu/commit/b3d3a426da9b067366bc132d53a6fa6b72675b55
  Author: Vincent Palatin <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  hax: fix breakage in locking

use qemu_mutex_lock_iothread consistently in qemu_hax_cpu_thread_fn() as
done in other _thread_fn functions, instead of grabbing directly the
BQL. This way we ensure that iothread_locked is properly set.

On v2.9.0-rc0, QEMU was dying in an assertion in the mutex code when
running with '--enable-hax' either on OSX or Windows. This bug was triggered
since the code modification for multithreading added new usages of
qemu_mutex_iothread_locked.
This fixes the breakage on both platforms, I can now run again a full
Chromium OS image with HAX kernel acceleration.

Signed-off-by: Vincent Palatin <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 940a8ce075e3408742a4edcabfd6c2a15e2539eb
      
https://github.com/qemu/qemu/commit/940a8ce075e3408742a4edcabfd6c2a15e2539eb
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M Makefile
    M cpus.c
    M hw/block/Makefile.objs
    M hw/char/Makefile.objs
    M hw/display/Makefile.objs
    M hw/net/Makefile.objs
    M hw/usb/Makefile.objs
    M hw/xen/Makefile.objs
    A include/qemu/systemd.h
    M qemu-nbd.c
    M qga/main.c
    M util/Makefile.objs
    A util/systemd.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging

fixes for 2.9-rc1, plus removal of -mno-cygwin references

# gpg: Signature made Mon 20 Mar 2017 11:25:07 GMT
# gpg:                using RSA key 0xBFFBD25F78C7AE83
# gpg: Good signature from "Paolo Bonzini <address@hidden>"
# gpg:                 aka "Paolo Bonzini <address@hidden>"
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* remotes/bonzini/tags/for-upstream:
  hax: fix breakage in locking
  configure: remove Cygwin
  xen: do not build backends for targets that do not support xen
  qemu-ga: obey LISTEN_PID when using systemd socket activation

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/373967b2ed63...940a8ce075e3