[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 02a4d8: qga: fix for default env processing f
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 02a4d8: qga: fix for default env processing for guest-exec |
Date: |
Wed, 18 Nov 2015 05:30:08 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 02a4d82e8c19267ad06b08389b5e914ba668450e
https://github.com/qemu/qemu/commit/02a4d82e8c19267ad06b08389b5e914ba668450e
Author: Yuri Pudgorodskiy <address@hidden>
Date: 2015-11-17 (Tue, 17 Nov 2015)
Changed paths:
M qga/commands.c
Log Message:
-----------
qga: fix for default env processing for guest-exec
envp == NULL must be passed inside gspawn() if it was not passed with
the command line. Original code inherits environment from the QGA,
which is wrong.
Signed-off-by: Yuri Pudgorodskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Michael Roth <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
Commit: 0be40839519215988e207b86bc1638de53567588
https://github.com/qemu/qemu/commit/0be40839519215988e207b86bc1638de53567588
Author: Yuri Pudgorodskiy <address@hidden>
Date: 2015-11-17 (Tue, 17 Nov 2015)
Changed paths:
M qga/commands.c
Log Message:
-----------
qga: allow to lookup in PATH from the passed envp for guest-exec
This was original behaviour before GLIB gspawn() rework and we rely on
this behaviour.
Signed-off-by: Yuri Pudgorodskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Michael Roth <address@hidden>
* add version check (2.33.2) for G_SPAWN_SEARCH_PATH_FROM_ENVP
Signed-off-by: Michael Roth <address@hidden>
Commit: ab59e3ecb2c12fafa89f7bedca7d329a078f3870
https://github.com/qemu/qemu/commit/ab59e3ecb2c12fafa89f7bedca7d329a078f3870
Author: Michael Roth <address@hidden>
Date: 2015-11-17 (Tue, 17 Nov 2015)
Changed paths:
M Makefile
Log Message:
-----------
makefile: fix w32 install target for qemu-ga
fafcaf1 added a 'qemu-ga' install target on w32, which can be used
in place of the existing qemu-ga.exe target to also handle dealing
with other components such as DLLs for VSS/fsfreeze and generating
an MSI package if appropriate configure options are present.
As part of that, qemu-ga$(EXESUF) was removed from $TOOLS in favor
of this new qemu-ga target.
The install rule however relies on a direct mapping of the $TOOLS
entry to the actual resulting binary. In the case of w32, qemu-ga
is not identical to qemu-ga$(EXESUF), and the install recipe fails
to find the 'qemu-ga' binary.
Fix this by essentially remapping 'qemu-ga' back to 'qemu-ga.exe'
in the install recipe.
This raises the question of whether or not qemu-ga should continue
to live in TOOLS as opposed to its own special target, but as a
late fix for a regression in 2.5 this commit should be safer, since
we rely on qemu-ga's presence in $TOOLS in several places throughout
Makefile.
Reported-by: Stefan Weil <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
Commit: ab9b872ab3147faf3c04e91d525815b9139dd996
https://github.com/qemu/qemu/commit/ab9b872ab3147faf3c04e91d525815b9139dd996
Author: Peter Maydell <address@hidden>
Date: 2015-11-18 (Wed, 18 Nov 2015)
Changed paths:
M Makefile
M qga/commands.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-11-13-v2-tag'
into staging
qemu-ga patch queue for 2.5
* fixes for guest-exec gspawn() usage:
- inherit default lookup path by default instead of
explicitly defining it as being empty.
- don't inherit default PATH when PATH/ENV are explicit
v2:
* added fix for w32 'make install' target
* added version check for new g_spawn() flag
# gpg: Signature made Tue 17 Nov 2015 22:33:03 GMT using RSA key ID F108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg: aka "Michael Roth <address@hidden>"
# gpg: aka "Michael Roth <address@hidden>"
* remotes/mdroth/tags/qga-pull-2015-11-13-v2-tag:
makefile: fix w32 install target for qemu-ga
qga: allow to lookup in PATH from the passed envp for guest-exec
qga: fix for default env processing for guest-exec
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/6b79f253a377...ab9b872ab314
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 02a4d8: qga: fix for default env processing for guest-exec,
GitHub <=