[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [COMMIT d9db889] kvm: Work around borken MSR_GET_INDEX_LI
From: |
Anthony Liguori |
Subject: |
[Qemu-commits] [COMMIT d9db889] kvm: Work around borken MSR_GET_INDEX_LIST |
Date: |
Fri, 10 Jul 2009 20:40:31 -0000 |
From: Jan Kiszka <address@hidden>
Allocate enough memory for KVM_GET_MSR_INDEX_LIST as older kernels shot
far beyond their limits, corrupting user space memory.
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 4a3f598..cab9fcc 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -239,8 +239,11 @@ static int kvm_has_msr_star(CPUState *env)
if (ret < 0)
return 0;
- kvm_msr_list = qemu_mallocz(sizeof(msr_list) +
- msr_list.nmsrs *
sizeof(msr_list.indices[0]));
+ /* Old kernel modules had a bug and could write beyond the provided
+ memory. Allocate at least a safe amount of 1K. */
+ kvm_msr_list = qemu_mallocz(MAX(1024, sizeof(msr_list) +
+ msr_list.nmsrs *
+ sizeof(msr_list.indices[0])));
kvm_msr_list->nmsrs = msr_list.nmsrs;
ret = kvm_ioctl(env->kvm_state, KVM_GET_MSR_INDEX_LIST, kvm_msr_list);
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [COMMIT d9db889] kvm: Work around borken MSR_GET_INDEX_LIST,
Anthony Liguori <=