[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [COMMIT 11a1feb] raw-posix: Remove O_RDWR when attemptin
From: |
Anthony Liguori |
Subject: |
[Qemu-commits] [COMMIT 11a1feb] raw-posix: Remove O_RDWR when attempting to open afile read-only |
Date: |
Tue, 16 Jun 2009 21:25:06 -0000 |
From: Avi Kivity <address@hidden>
When we open a file, we first attempt to open it read-write, then fall back
to read-only. Unfortunately we reuse the flags from the previous attempt,
so both attempts try to open the file with write permissions, and fail.
Fix by clearing the O_RDWR flag from the previous attempt.
Signed-off-by: Avi Kivity <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 5790206..ccb014a 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -133,6 +133,7 @@ static int raw_open_common(BlockDriverState *bs, const char
*filename,
s->lseek_err_cnt = 0;
s->open_flags |= O_BINARY;
+ s->open_flags &= ~O_ACCMODE;
if ((flags & BDRV_O_ACCESS) == BDRV_O_RDWR) {
s->open_flags |= O_RDWR;
} else {
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [COMMIT 11a1feb] raw-posix: Remove O_RDWR when attempting to open afile read-only,
Anthony Liguori <=