[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fast8_t is not 8
From: |
Jamie Lokier |
Subject: |
Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fast8_t is not 8 bits onOpenBSD/Sparc64 |
Date: |
Sat, 13 Jun 2009 19:17:12 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Blue Swirl wrote:
> On 6/13/09, Paul Brook <address@hidden> wrote:
> > On Saturday 13 June 2009, Anthony Liguori wrote:
> > > + asid = env->tlb->mmu.r4k.tlb[i].ASID;
> > > + qemu_put_8s(f, &asid);
> >
> > Wouldn't it be simpler to just use qemu_put_byte?
>
> uint_fast8_t equals uint32_t on OpenBSD/Sparc64. It's also big endian,
> so qemu_put_byte(f, &env->tlb->mmu.r4k.tlb[i].ASID) writes the MSB
> (==0).
I would hope it outputs a great big warning, or even better an error
(see __builtin_error()) when you try :-)
-- Jamie