Re: [PATCH 2/2] hw/block/block.c: improve confusing blk_check_size_and_read_all() error

[Philippe Mathieu-Daudé]

On 23/1/24 09:09, Manos Pitsidianakis wrote:
> In cases where a device tries to read more bytes than the block device
> contains, the error is vague: "device requires X bytes, block backend
> provides Y bytes".
>
> This patch changes the errors of this function to include the block
> backend name, the device id and device type name where appropriate.
>
> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> ---
>   hw/block/block.c         | 25 +++++++++++++++----------
>   hw/block/m25p80.c        |  3 ++-
>   hw/block/pflash_cfi01.c  |  4 ++--
>   hw/block/pflash_cfi02.c  |  2 +-
>   include/hw/block/block.h |  4 ++--
>   5 files changed, 22 insertions(+), 16 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>