[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 02/10] parallels: Incorrect data end calculation in parallels_
From: |
Alexander Ivanov |
Subject: |
[PATCH v8 02/10] parallels: Incorrect data end calculation in parallels_open() |
Date: |
Tue, 18 Jul 2023 12:44:24 +0200 |
The BDRVParallelsState structure contains data_end field that is measured
in sectors. In parallels_open() initially this field is set by data_off
field from parallels image header.
According to the parallels format documentation, data_off field contains
an offset, in sectors, from the start of the file to the start of the
data area. For "WithoutFreeSpace" images: if data_off is zero, the offset
is calculated as the end of the BAT table plus some padding to ensure
sector size alignment.
The parallels_open() function has code for handling zero value in
data_off, but in the result data_end contains the offset in bytes.
Replace the alignment to sector size by division by sector size and fix
the comparision with s->header_size.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
---
block/parallels.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index c7b2ed5a54..3c0dca3dbf 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -865,9 +865,9 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
}
s->data_end = le32_to_cpu(ph.data_off);
if (s->data_end == 0) {
- s->data_end = ROUND_UP(bat_entry_off(s->bat_size), BDRV_SECTOR_SIZE);
+ s->data_end = DIV_ROUND_UP(size, BDRV_SECTOR_SIZE);
}
- if (s->data_end < s->header_size) {
+ if (s->data_end < (s->header_size >> BDRV_SECTOR_BITS)) {
/*
* There is not enough unused space to fit to block align between BAT
* and actual data. We can't avoid read-modify-write...
--
2.34.1
- [PATCH v8 00/10] parallels: Add duplication check, repair at open, fix bugs, Alexander Ivanov, 2023/07/18
- [PATCH v8 05/10] parallels: Add data_start field to BDRVParallelsState, Alexander Ivanov, 2023/07/18
- [PATCH v8 01/10] parallels: Fix comments formatting inside parallels driver, Alexander Ivanov, 2023/07/18
- [PATCH v8 07/10] parallels: Image repairing in parallels_open(), Alexander Ivanov, 2023/07/18
- [PATCH v8 02/10] parallels: Incorrect data end calculation in parallels_open(),
Alexander Ivanov <=
- [PATCH v8 03/10] parallels: Check if data_end greater than the file size, Alexander Ivanov, 2023/07/18
- [PATCH v8 09/10] parallels: Add data_off check, Alexander Ivanov, 2023/07/18
- [PATCH v8 06/10] parallels: Add checking and repairing duplicate offsets in BAT, Alexander Ivanov, 2023/07/18
- [PATCH v8 08/10] parallels: Use bdrv_co_getlength() in parallels_check_outside_image(), Alexander Ivanov, 2023/07/18
- [PATCH v8 04/10] parallels: Add "explicit" argument to parallels_check_leak(), Alexander Ivanov, 2023/07/18
- [PATCH v8 10/10] parallels: Add data_off repairing to parallels_open(), Alexander Ivanov, 2023/07/18