[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] nbd/server: Allow MULTI_CONN for shared writable expo
From: |
Richard W.M. Jones |
Subject: |
Re: [PATCH v3 3/3] nbd/server: Allow MULTI_CONN for shared writable exports |
Date: |
Tue, 15 Mar 2022 13:14:41 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The patches seem OK to me, but I don't really know enough about the
internals of qemu-nbd to give a line-by-line review. I did however
build and test qemu-nbd with the patches:
$ ./build/qemu-nbd /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
$ ./build/qemu-nbd -e 2 /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
^^^ Is this expected? It also happens with -e 0.
$ ./build/qemu-nbd -e 2 -m on /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: true
$ ./build/qemu-nbd -e 2 -m off /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW