Re: [Qemu-block] [PATCH v2] blockdev: loosen restrictions on drive-backup source node

[Max Reitz]

On 21.05.19 23:00, John Snow wrote:
> We mandate that the source node must be a root node; but there's no reason
> I am aware of that it needs to be restricted to such. In some cases, we need
> to make sure that there's a medium present, but in the general case we can
> allow the backup job itself to do the graph checking.
> 
> This patch helps improve the error message when you try to backup from
> the same node more than once, which is reflected in the change to test
> 056.
> 
> For backups with bitmaps, it will also show a better error message that
> the bitmap is in use instead of giving you something cryptic like "need
> a root node."
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1707303
> Signed-off-by: John Snow <address@hidden>
> ---
>  blockdev.c             | 7 ++++++-
>  tests/qemu-iotests/056 | 2 +-
>  2 files changed, 7 insertions(+), 2 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Let’s see what breaks.

Max

signature.asc
Description: OpenPGP digital signature