[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 8/8] block/fileposix: extend to use io_uring
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH v3 8/8] block/fileposix: extend to use io_uring |
|
Date: |
Mon, 27 May 2019 10:42:07 +0100 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, May 27, 2019 at 01:33:27PM +0530, Aarushi Mehta wrote:
> @@ -1920,24 +1947,40 @@ static int coroutine_fn
> raw_co_pwritev(BlockDriverState *bs, uint64_t offset,
>
> static void raw_aio_plug(BlockDriverState *bs)
> {
> -#ifdef CONFIG_LINUX_AIO
> +#if defined CONFIG_LINUX_AIO || defined CONFIG_LINUX_IO_URING
> BDRVRawState *s = bs->opaque;
> +#endif
It would be nice to avoid the extra ifdefs. Here is an alternative
without #ifdef:
BDRVRawState __attribute__((unused)) *s = bs->opaque;
> @@ -1963,8 +2006,10 @@ static int raw_co_flush_to_disk(BlockDriverState *bs)
> static void raw_aio_attach_aio_context(BlockDriverState *bs,
> AioContext *new_context)
> {
> +#if defined CONFIG_LINUX_AIO || defined CONFIG_LINUX_IO_URING
> + BDRVRawState *s = bs->opaque;
Indentation?
signature.asc
Description: PGP signature
- Re: [Qemu-block] [PATCH v3 2/8] qapi/block-core: add option for io_uring, (continued)
- [Qemu-block] [PATCH v3 3/8] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/05/27
- [Qemu-block] [PATCH v3 4/8] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/05/27
- [Qemu-block] [PATCH v3 5/8] stubs: add stubs for io_uring interface, Aarushi Mehta, 2019/05/27
- [Qemu-block] [PATCH v3 6/8] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/05/27
- [Qemu-block] [PATCH v3 7/8] blockdev: accept io_uring as option, Aarushi Mehta, 2019/05/27
- [Qemu-block] [PATCH v3 8/8] block/fileposix: extend to use io_uring, Aarushi Mehta, 2019/05/27
- Re: [Qemu-block] [PATCH v3 8/8] block/fileposix: extend to use io_uring,
Stefan Hajnoczi <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/8] Add support for io_uring, no-reply, 2019/05/27
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/8] Add support for io_uring, no-reply, 2019/05/27