Re: [Qemu-block] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

[Thomas Huth]

Am Sun, 26 May 2019 00:50:13 +0200
schrieb Laurent Vivier <address@hidden>:

> If you want to test the machine, it doesn't yet boot a MacROM, but
> you can boot a linux kernel from the command line.
> 
> You can install your own disk using debian-installer with:
> 
>     ./qemu-system-m68k \
>     -M q800 \
>     -serial none -serial mon:stdio \
>     -m 1000M -drive file=m68k.qcow2,format=qcow2 \
>     -net nic,model=dp83932,addr=09:00:07:12:34:57 \
>     -append "console=ttyS0 vga=off" \
>     -kernel vmlinux-4.15.0-2-m68k \
>     -initrd initrd.gz \
>     -drive file=debian-9.0-m68k-NETINST-1.iso \
>     -drive file=m68k.qcow2,format=qcow2 \
>     -nographic
> 
> If you use a graphic adapter instead of "-nographic", you can use
> "-g" to set the size of the display (I use "-g 1600x800x24").
> 
> Co-developed-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  MAINTAINERS                      |  14 ++
>  default-configs/m68k-softmmu.mak |   1 +
>  hw/m68k/Kconfig                  |  12 +
>  hw/m68k/Makefile.objs            |   1 +
>  hw/m68k/bootinfo.h               | 100 +++++++++
>  hw/m68k/q800.c                   | 369
> +++++++++++++++++++++++++++++++ 6 files changed, 497 insertions(+)
>  create mode 100644 hw/m68k/bootinfo.h
>  create mode 100644 hw/m68k/q800.c
[...]
> diff --git a/hw/m68k/bootinfo.h b/hw/m68k/bootinfo.h
> new file mode 100644
> index 0000000000..6584775f6d
> --- /dev/null
> +++ b/hw/m68k/bootinfo.h
> @@ -0,0 +1,100 @@
> +struct bi_record {
> +    uint16_t tag;        /* tag ID */
> +    uint16_t size;       /* size of record */
> +    uint32_t data[0];    /* data */
> +};

Maybe add a short description, license information and header guards at
the top of the file?

Apart from that, the patch looks sane to me.

 Thomas