[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH v2 3/9] include/block: declare interfaces fo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [RFC PATCH v2 3/9] include/block: declare interfaces for io_uring |
Date: |
Fri, 24 May 2019 16:16:15 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Fri, May 24, 2019 at 07:33:31PM +0530, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <address@hidden>
> ---
> include/block/aio.h | 16 +++++++++++++++-
> include/block/raw-aio.h | 15 +++++++++++++++
> 2 files changed, 30 insertions(+), 1 deletion(-)
There's not much a code reviewer can do with this patch in isolation
since they don't know the behavior of the functions declared here.
Please squash this patch with the patch containing the function
definitions. That way a full review can be done to decide "is this the
correct function prototype?", "can the interface be simplified?", etc.
signature.asc
Description: PGP signature
- [Qemu-block] [RFC PATCH v2 0/9] Add support for io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 5/9] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 4/9] stubs: add aio interface stubs for io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 3/9] include/block: declare interfaces for io_uring, Aarushi Mehta, 2019/05/24
- Re: [Qemu-block] [RFC PATCH v2 3/9] include/block: declare interfaces for io_uring,
Stefan Hajnoczi <=
- [Qemu-block] [RFC PATCH v2 2/9] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 1/9] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 8/9] block/file-posix: extends to use with io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 9/9] configure: permit use of io_uring, Aarushi Mehta, 2019/05/24
- [Qemu-block] [RFC PATCH v2 7/9] blockdev: accept io_uring as option, Aarushi Mehta, 2019/05/24