[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 4/5] iotests: Use qemu-nbd's --pid-file
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 4/5] iotests: Use qemu-nbd's --pid-file |
Date: |
Fri, 24 May 2019 09:52:22 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/8/19 4:18 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/common.rc | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 93f87389b6..5502c3da2f 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -105,10 +105,8 @@ _qemu_io_wrapper()
>
> _qemu_nbd_wrapper()
> {
> - (
> - echo $BASHPID > "${QEMU_TEST_DIR}/qemu-nbd.pid"
> - exec "$QEMU_NBD_PROG" $QEMU_NBD_OPTIONS "$@"
> - )
> + "$QEMU_NBD_PROG" --pid-file="${QEMU_TEST_DIR}/qemu-nbd.pid" \
> + $QEMU_NBD_OPTIONS "$@"
> }
>
> _qemu_vxhs_wrapper()
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 0/5] iotests: Let 233 run concurrently, Max Reitz, 2019/05/08
- [Qemu-block] [PATCH v3 1/5] qemu-nbd: Add --pid-file option, Max Reitz, 2019/05/08
- [Qemu-block] [PATCH v3 2/5] iotests.py: Add qemu_nbd_early_pipe(), Max Reitz, 2019/05/08
- [Qemu-block] [PATCH v3 3/5] qemu-nbd: Do not close stderr, Max Reitz, 2019/05/08
- [Qemu-block] [PATCH v3 4/5] iotests: Use qemu-nbd's --pid-file, Max Reitz, 2019/05/08
- Re: [Qemu-block] [PATCH v3 4/5] iotests: Use qemu-nbd's --pid-file,
Eric Blake <=
- [Qemu-block] [PATCH v3 5/5] iotests: Let 233 run concurrently, Max Reitz, 2019/05/08
- Re: [Qemu-block] [PATCH v3 0/5] iotests: Let 233 run concurrently, Eric Blake, 2019/05/24