[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block/file-posix: update .help
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block/file-posix: update .help of BLOCK_OPT_PREALLOC option |
Date: |
Thu, 23 May 2019 18:36:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Stefano Garzarella <address@hidden> writes:
> Show 'falloc' among the allowed values of 'preallocation'
> option, only when it is supported (if defined CONFIG_POSIX_FALLOCATE)
>
> Signed-off-by: Stefano Garzarella <address@hidden>
> ---
> block/file-posix.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index d018429672..9632e3a87b 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -2751,7 +2751,11 @@ static QemuOptsList raw_create_opts = {
> {
> .name = BLOCK_OPT_PREALLOC,
> .type = QEMU_OPT_STRING,
> - .help = "Preallocation mode (allowed values: off, falloc, full)"
> + .help = "Preallocation mode (allowed values: off"
> +#ifdef CONFIG_POSIX_FALLOCATE
> + ", falloc"
> +#endif
> + ", full)"
> },
> { /* end of list */ }
> }
Reviewed-by: Markus Armbruster <address@hidden>