[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 5/5] block/backup: refactor: split out backup
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [Qemu-block] [PATCH v7 5/5] block/backup: refactor: split out backup_calculate_cluster_size |
|
Date: |
Mon, 13 May 2019 09:54:08 +0000 |
09.05.2019 19:12, Max Reitz wrote:
> On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote:
>> Split out cluster_size calculation. Move copy-bitmap creation above
>> block-job creation, as we are going to share it with upcoming
>> backup-top filter, which also should be created before actual block job
>> creation.
>>
>> Also, while being here, drop unnecessary "goto error" from
>> bdrv_getlength error path.
>
> This paragraph should be dropped now. Do you mind me doing it?
>
Of course, don't mind)
--
Best regards,
Vladimir