[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes |
Date: |
Mon, 6 May 2019 00:15:31 +0200 |
Hi,
While reviewing Stephen Checkoway's v4 "Implement missing AMD
pflash functionality" [*] I found it hard (for me) to digest,
so I took step by step notes. This series is the result of
those notes.
Regarding Stephen's series, this series only contains the
generic code movement and trivial cleanup. The other patches
are rather dense and I need more time to study the specs.
Stephen: If you take out the patch #2 ("Use the GLib API"),
you can rebase your series on top of this.
I'd appreciate if you can adapt your tests to use the GLib
functions, else I plan to do it later.
Regards,
Phil.
[*] https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg04595.html
Philippe Mathieu-Daudé (10):
tests/pflash-cfi02: Use the GLib API
tests/pflash-cfi02: Use IEC binary prefixes for size constants
hw/block/pflash_cfi02: Fix debug format string
hw/block/pflash_cfi02: Add an enum to define the write cycles
hw/block/pflash_cfi02: Add helpers to manipulate the status bits
hw/block/pflash_cfi02: Simplify a statement using fall through
hw/block/pflash_cfi02: Use the ldst API in pflash_write()
hw/block/pflash_cfi02: Use the ldst API in pflash_read()
hw/block/pflash_cfi02: Extract the pflash_data_read() function
hw/block/pflash_cfi02: Unify the MemoryRegionOps
Stephen Checkoway (3):
tests/pflash-cfi02: Add test for supported CFI commands
hw/block/pflash_cfi02: Fix command address comparison
hw/block/pflash_cfi02: Use the chip erase time specified in the CFI
table
hw/block/pflash_cfi02.c | 234 +++++++++++++++++---------------------
tests/Makefile.include | 2 +
tests/pflash-cfi02-test.c | 232 +++++++++++++++++++++++++++++++++++++
3 files changed, 339 insertions(+), 129 deletions(-)
create mode 100644 tests/pflash-cfi02-test.c
--
2.20.1
- [Qemu-block] [PATCH 00/13] hw/block/pflash_cfi02: Clean-up and fixes,
Philippe Mathieu-Daudé <=
- [Qemu-block] [PATCH 02/13] tests/pflash-cfi02: Use the GLib API, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 09/13] hw/block/pflash_cfi02: Use the ldst API in pflash_read(), Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 10/13] hw/block/pflash_cfi02: Extract the pflash_data_read() function, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 01/13] tests/pflash-cfi02: Add test for supported CFI commands, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 08/13] hw/block/pflash_cfi02: Use the ldst API in pflash_write(), Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 07/13] hw/block/pflash_cfi02: Simplify a statement using fall through, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 11/13] hw/block/pflash_cfi02: Unify the MemoryRegionOps, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 04/13] hw/block/pflash_cfi02: Fix debug format string, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 05/13] hw/block/pflash_cfi02: Add an enum to define the write cycles, Philippe Mathieu-Daudé, 2019/05/05
- [Qemu-block] [PATCH 13/13] hw/block/pflash_cfi02: Use the chip erase time specified in the CFI table, Philippe Mathieu-Daudé, 2019/05/05