Re: [Qemu-block] [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support

[Thomas Huth]

On 01/05/2019 14.06, Eric Blake wrote:
> On 5/1/19 6:08 AM, Alex Bennée wrote:
>>
>> Thomas Huth <address@hidden> writes:
>>
>>> "check -raw 005" fails when running on ext4 filesystems - these do not
>>> support such large sparse files. Use the same check as in test 220 to
>>> skip the test in this case.
>>>
>>> Suggested-by: Eric Blake <address@hidden>
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> ---
>>>  tests/qemu-iotests/005 | 9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005
>>> index 2fef63af88..6136ced5c8 100755
>>> --- a/tests/qemu-iotests/005
>>> +++ b/tests/qemu-iotests/005
>>> @@ -55,6 +55,15 @@ if [ "$IMGPROTO" = "sheepdog" ]; then
>>>      _notrun "image protocol $IMGPROTO does not support large image sizes"
>>>  fi
>>>
>>> +# Sanity check: For raw, we require a file system that permits the creation
>>> +# of a HUGE (but very sparse) file.  tmpfs works, ext4 does not.
>>
>> Is this comment correct? Running on my ext4 home partition this test
>> seems to be running fine and not skipping. Indeed:
> 
>>> +if [ "$IMGFMT" = "raw" ]; then
>>> +    if ! truncate --size=5T "$TEST_IMG"; then
> 
> 5T fits on ext4 but not ext3.

It fails for me on my ext4 partition. Anyway, I'll change the comment.

 Thomas

signature.asc
Description: OpenPGP digital signature