[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/13] block: Allow freezing Bdr
Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/13] block: Allow freezing BdrvChild links
Wed, 13 Mar 2019 16:01:37 +0100
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)
On Wed 13 Mar 2019 03:32:09 PM CET, Alberto Garcia wrote:
>>> > 2. And therefore, why we just don't call bdrv_replace_node(top,
>>> > base, errp) from bdrv_drop_intermediate?
>>> I think that would not call role->update_filename().
>> And role->update_filename() involves I/O, so you can't roll back
>> across it anyway. I think this was the reason why we didn't roll back
>> the in-memory state either, it would become inconsistent with what is
>> on the disk.
> But I think at least for the bdrv_check_update_perm() case we should
> call bdrv_abort_perm_update() on all nodes if things fail, and we're
> currently not doing it.
Forget this, bdrv_replace_child() already sets the new permissions after
every iteration of the loop, so the only place that needs to call
bdrv_abort_perm_update() is where we are doing it already.
[Qemu-block] [PATCH v2 13/13] qemu-iotests: Test the x-blockdev-reopen QMP command, Alberto Garcia, 2019/03/06
[Qemu-block] [PATCH v2 12/13] block: Add an 'x-blockdev-reopen' QMP command, Alberto Garcia, 2019/03/06
[Qemu-block] [PATCH v2 02/13] block: Freeze the backing chain for the duration of the commit job, Alberto Garcia, 2019/03/06
[Qemu-block] [PATCH v2 07/13] block: Allow omitting the 'backing' option in certain cases, Alberto Garcia, 2019/03/06
- Re: [Qemu-block] [PATCH v2 09/13] block: Add a 'mutable_opts' field to BlockDriver, (continued)